Date: Fri, 08 Jun 2012 20:48:38 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Gabor Kovesdan <gabor@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r236759 - head/usr.bin/sort Message-ID: <4FD24906.8080209@FreeBSD.org> In-Reply-To: <4FD2369D.6040503@FreeBSD.org> References: <201206081708.q58H8RRw072192@svn.freebsd.org> <4FD2369D.6040503@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-06-08 19:30, Gabor Kovesdan wrote:
> On 2012.06.08. 19:08, Dimitry Andric wrote:
...
>> -#define UNUSED_ARG(A) do { A=A; } while(0)
>> +#define UNUSED_ARG(A) do { (void)(A); } while(0)
> My fault, I should have fixed this. But what about this version? I think
> it is more elegant and this is how it should have been done initially:
No worries, I just used the least disruptive way of fixing it. Note
that it also only occurs specifically when you compile with -save-temps
or with ccache, which does preprocessing and compiling separately.
Your new diff looks good to me. Though please attach diffs next time,
for some reason your mail client (or mine) badly mangled the tabs, and
it was tricky to apply. :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FD24906.8080209>