From owner-cvs-all@FreeBSD.ORG Wed Jun 2 16:05:05 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6061A16A4CE; Wed, 2 Jun 2004 16:05:05 -0700 (PDT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id D94D443D39; Wed, 2 Jun 2004 16:05:04 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: from [192.168.0.12] (g4.samsco.home [192.168.0.12]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i52NC8Os020288; Wed, 2 Jun 2004 17:12:08 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <40BE5CE4.60304@freebsd.org> Date: Wed, 02 Jun 2004 17:04:04 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040514 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Maxime Henrion References: <200406022252.i52MqJFp094240@repoman.freebsd.org> In-Reply-To: <200406022252.i52MqJFp094240@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2004 23:05:05 -0000 Maxime Henrion wrote: > mux 2004/06/02 15:52:18 PDT > > FreeBSD src repository > > Modified files: > sys/dev/fxp if_fxp.c if_fxpvar.h > Log: > Use the device sysctl tree instead of rolling our own. Some of the > sysctls were global (hw.fxp_rnr and hw.fxp_noflow), all of them are > now per-device. Sample output of "sysctl dev.fxp0" with this patch, > with the standard %foo nodes removed : > > dev.fxp0.int_delay: 1000 > dev.fxp0.bundle_max: 6 > dev.fxp0.rnr: 0 > dev.fxp0.noflow: 0 > > Revision Changes Path > 1.213 +18 -24 src/sys/dev/fxp/if_fxp.c > 1.31 +2 -2 src/sys/dev/fxp/if_fxpvar.h Not having the ability to deal with global settings is a bit of a pain. I had envisioned that something like this would be: dev.fxp.N.instance_variable dev.fxp.global_variable Anyways, this work still looks very nice =-) Scott