From owner-p4-projects@FreeBSD.ORG Tue Dec 13 00:45:48 2005 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 0C4A316A422; Tue, 13 Dec 2005 00:45:48 +0000 (GMT) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BFC6F16A41F; Tue, 13 Dec 2005 00:45:47 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 451BF43D77; Tue, 13 Dec 2005 00:45:41 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.13.4/8.13.4) with ESMTP id jBD0jZY5026437; Mon, 12 Dec 2005 16:45:37 -0800 (PST) (envelope-from marcel@xcllnt.net) In-Reply-To: <200512122158.jBCLwwCt085740@repoman.freebsd.org> References: <200512122158.jBCLwwCt085740@repoman.freebsd.org> Mime-Version: 1.0 (Apple Message framework v746.2) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <3D3166CC-DBC3-45C1-B78B-5CFE5F57C580@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Mon, 12 Dec 2005 16:45:32 -0800 To: Warner Losh X-Mailer: Apple Mail (2.746.2) Cc: Perforce Change Reviews Subject: Re: PERFORCE change 88102 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2005 00:45:48 -0000 On Dec 12, 2005, at 9:58 PM, Warner Losh wrote: > http://perforce.freebsd.org/chv.cgi?CH=88102 > > Change 88102 by imp@imp_Speedy on 2005/12/12 21:58:35 > > Make uart_subr not depend on ns8250.o This is not such a good change. As the comment says in uart_subr.c, it's just a default. There's nothing PC specific about it. It's the the most common case and therefore a sensible default. Now, if it makes sense to have MD specific defaults and not MI defaults, then it makes sense to have ALL the defaults set in MD code and none in MI code (or if they are set in MI code, they should be set before MD defaults can be set to override the MI defaults). What really needs to be done is add support for the DT tag, so that you can set the device type in the environment.... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net