From owner-svn-src-head@FreeBSD.ORG Mon Jan 19 07:58:29 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B9A401065670; Mon, 19 Jan 2009 07:58:29 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 6D0F58FC24; Mon, 19 Jan 2009 07:58:29 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.local (pooker.samsco.org [168.103.85.57]) by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id n0J7wP47036336; Mon, 19 Jan 2009 00:58:25 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <497432A1.9060805@samsco.org> Date: Mon, 19 Jan 2009 00:58:25 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9 MIME-Version: 1.0 To: Maxim Sobolev References: <200901190710.n0J7ACSg001385@svn.freebsd.org> In-Reply-To: <200901190710.n0J7ACSg001385@svn.freebsd.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=3.8 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r187426 - head/sys/amd64/conf X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jan 2009 07:58:30 -0000 Maxim Sobolev wrote: > Author: sobomax > Date: Mon Jan 19 07:10:11 2009 > New Revision: 187426 > URL: http://svn.freebsd.org/changeset/base/187426 > > Log: > Add asr(4) and stge(4) from i386 GENERIC. Both drivers compile on amd64 and > there is no particular reason for them to be i386-only. Yes, there is a particular reason why asr is i386 only. This has been discussed extensively over the years, but to sum it up, no it is not 64-bit clean. Please remove. At this point in the lifecycle of amd64, you can be 100% assured that the list of compatible devices has been checked and rechecked a few dozen times. You are not going to find hidden gems that people have forgotten about. If you think you've found something, ask first, and prepare to be wrong. And above all else, don't put drivers into here that you haven't tested. It's pretty silly to admit in your commit message, for all to see, that you are blatantly committing without testing. Scott