Date: Wed, 5 Jun 2019 15:08:56 +0300 From: Lev Serebryakov <lev@FreeBSD.org> To: Slawa Olhovchenkov <slw@zxy.spb.ru>, Ian Lepore <ian@freebsd.org> Cc: freebsd-fs@freebsd.org, freebsd-hackers@FreeBSD.org, Alexander Motin <mav@FreeBSD.org> Subject: Re: Commit r345200 (new ARC reclamation threads) looks suspicious to me. Message-ID: <1644469784.20190605150856@serebryakov.spb.ru> In-Reply-To: <20190531151202.GG47119@zxy.spb.ru> References: <55989579-a228-498e-2842-453cad6f315f@FreeBSD.org> <174f71126ca39907370a8904c07546b712ad91b9.camel@freebsd.org> <20190531151202.GG47119@zxy.spb.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello Slawa, Friday, May 31, 2019, 6:12:02 PM, you wrote: > What about arc_no_grow, for example? > arc_no_grow set in arc_reap_cb_check(), called from arc_reap_zthr > thread and in arc_lowmem(). > arc_no_grow test in arc_adapt(), called from > arc_read()/arc_get_data_impl() called from many unsynced thread. > How synced visibility of this varibale? I don;t like this one either. It is set under mutex (t->zthr_lock of reap thread/timer), but looks like tit is read by many other threads... And `arc_lowmem()` uses `arc_adjust_lock`... -- Best regards, Lev mailto:lev@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1644469784.20190605150856>