From owner-svn-ports-head@freebsd.org  Tue Jan  3 11:15:43 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 08025C9B328;
 Tue,  3 Jan 2017 11:15:43 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E07AA1E17;
 Tue,  3 Jan 2017 11:15:42 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 37681315A; Tue,  3 Jan 2017 11:15:42 +0000 (UTC)
To: ports-committers@freebsd.org, sunpoet@FreeBSD.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r430238 - head/databases/rocksdb
In-Reply-To: <201701010417.v014HjI0080871@repo.freebsd.org>
Message-Id: <20170103111542.37681315A@freefall.freebsd.org>
Date: Tue,  3 Jan 2017 11:15:42 +0000 (UTC)
From: jbeich@freebsd.org (Jan Beich)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jan 2017 11:15:43 -0000

Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> writes:

> --- head/databases/rocksdb/Makefile	Sun Jan  1 03:57:43 2017	(r430237)
> +++ head/databases/rocksdb/Makefile	Sun Jan  1 04:17:45 2017	(r430238)
> @@ -50,10 +50,6 @@ ZSTD_LIB_DEPENDS=	libzstd.so:archivers/z
>  
>  .include <bsd.port.pre.mk>
>  
> -.if ${OSVERSION} <= 1000000
> -CFLAGS+=	-D_GLIBCXX_USE_C99
> -.endif
> -

This may be premature. The underlying issue is documented in bug 193528
and has only been fixed in lang/gcc6 but not in lang/gcc or lang/gcc5.
Architectures still stuck with base GCC (sparc64, powerpc*, mips*) are
going to be BROKEN. And let's not forget users that prefer GCC over
Clang for various reasons e.g., -Og, -flto, -fopenmp on i386, Graphite.

$ uname -rp
12.0-CURRENT amd64
$ pkg install -qy gcc
$ make clean all CC=gcc49 CXX=g++49 CPP=cpp49
[...]
util/options_helper.cc: In function 'uint64_t rocksdb::ParseUint64(const string&)':
util/options_helper.cc:260:18: error: 'stoull' is not a member of 'std'
   uint64_t num = std::stoull(value.c_str(), &endchar);
                  ^
util/options_helper.cc: In function 'int rocksdb::{anonymous}::ParseInt(const string&)':
util/options_helper.cc:378:13: error: 'stoi' is not a member of 'std'
   int num = std::stoi(value.c_str(), &endchar);
             ^
util/options_helper.cc: In function 'double rocksdb::{anonymous}::ParseDouble(const string&)':
util/options_helper.cc:416:10: error: 'stod' is not a member of 'std'
   return std::stod(value);
          ^
util/options_helper.cc:420:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^