From owner-svn-src-all@freebsd.org Fri Aug 12 00:29:46 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9C68BB5DF0; Fri, 12 Aug 2016 00:29:46 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 9E71D196B; Fri, 12 Aug 2016 00:29:46 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 91B811C24; Fri, 12 Aug 2016 00:29:46 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 59176212F2; Fri, 12 Aug 2016 00:29:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id mm0iby2LRfW9; Fri, 12 Aug 2016 00:29:42 +0000 (UTC) Subject: Re: svn commit: r303019 - head/sys/geom DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com CAC4F212EB To: Peter Wemm , svn-src-all@freebsd.org References: <201607190536.u6J5aLl7015268@repo.freebsd.org> <3277576.dFZ2EGo2Fh@overcee.wemm.org> <6198652.UmU69kS6Zt@overcee.wemm.org> <181fcc35-3a5d-043f-7dc4-7a01a53eebae@FreeBSD.org> Cc: svn-src-head@freebsd.org, "Andrey V. Elsukov" , src-committers@freebsd.org From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: Date: Thu, 11 Aug 2016 17:29:41 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <181fcc35-3a5d-043f-7dc4-7a01a53eebae@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2kcffhj5W2J6CgSSdv55iWKmGb5JENCdA" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2016 00:29:46 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2kcffhj5W2J6CgSSdv55iWKmGb5JENCdA Content-Type: multipart/mixed; boundary="17WHJ3RAvddNgIinO1Obf5qvVSbp4CkOE" From: Bryan Drewery To: Peter Wemm , svn-src-all@freebsd.org Cc: svn-src-head@freebsd.org, "Andrey V. Elsukov" , src-committers@freebsd.org Message-ID: Subject: Re: svn commit: r303019 - head/sys/geom References: <201607190536.u6J5aLl7015268@repo.freebsd.org> <3277576.dFZ2EGo2Fh@overcee.wemm.org> <6198652.UmU69kS6Zt@overcee.wemm.org> <181fcc35-3a5d-043f-7dc4-7a01a53eebae@FreeBSD.org> In-Reply-To: <181fcc35-3a5d-043f-7dc4-7a01a53eebae@FreeBSD.org> --17WHJ3RAvddNgIinO1Obf5qvVSbp4CkOE Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 8/11/2016 5:26 PM, Bryan Drewery wrote: > On 7/23/2016 10:27 PM, Peter Wemm wrote: >> On Saturday, July 23, 2016 09:39:00 PM Peter Wemm wrote: >>> On Tuesday, July 19, 2016 05:36:21 AM Andrey V. Elsukov wrote: >>>> Author: ae >>>> Date: Tue Jul 19 05:36:21 2016 >>>> New Revision: 303019 >>>> URL: https://svnweb.freebsd.org/changeset/base/303019 >>>> >>>> Log: >>>> Use g_resize_provider() to change the size of GEOM_DISK provider, >>>> when it is being opened. This should fix the possible loss of a re= size >>>> event when disk capacity changed. >>> >>> Are you sure about this? We have machines in the freebsd.org cluster= that >>> now panic on boot: >>> >>> Trying to mount root from zfs:zroot []... >>> GEOM_PART: da0 was automatically resized. >>> Use `gpart commit da0` to save changes or `gpart undo da0` to rever= t them. >>> GEOM_PART: integrity check failed (da0, GPT) >>> >>> Fatal trap 12: page fault while in kernel mode >>> cpuid =3D 1; apic id =3D 01 >>> fault virtual address =3D 0x48 >>> fault code =3D supervisor read data, page not present >>> instruction pointer =3D 0x20:0xffffffff80740005 >>> stack pointer =3D 0x28:0xfffffe01f119db10 >>> frame pointer =3D 0x28:0xfffffe01f119db30 >>> code segment =3D base 0x0, limit 0xfffff, type 0x1b >>> =3D DPL 0, pres 1, long 1, def32 0, gran 1 >>> processor eflags =3D interrupt enabled, resume, IOPL =3D 0 >>> current process =3D 13 (g_event) >>> [ thread pid 13 tid 100019 ] >>> Stopped at g_part_resize+0x35: testb $0x8,0x48(%rbx) >>> >>> >>> >>> db> where >>> Tracing pid 13 tid 100019 td 0xfffff8000426fa00 >>> g_part_resize() at g_part_resize+0x35/frame 0xfffffe01f119db30 >>> g_resize_provider_event() at g_resize_provider_event+0xb5/frame >>> 0xfffffe01f119d0 g_run_events() at g_run_events+0x20e/frame >>> 0xfffffe01f119dbb0 >>> .. >>> >>> It is exploding here: >>> g_part_resize(struct g_consumer *cp) >>> { >>> struct g_part_table *table; >>> >>> G_PART_TRACE((G_T_TOPOLOGY, "%s(%s)", __func__, >>> cp->provider->name)); g_topology_assert(); >>> >>> table =3D cp->geom->softc; >>> if (table->gpt_opened =3D=3D 0) { >>> ^^^^^^^^^ (table is null) >>> >>> Are you creating events too soon now? >> >> Sometimes da0 fails, other times da1 fails.. and sometimes it is compl= etely=20 >> fine. There is some sort of race going on with this change during the= very=20 >> first moments of bootup. >> >=20 > On r303467 I ran into this: >=20 > panic @ time 1470916206.652, thread 0xfffff8000412f000: > g_resize_provider_event but withered > cpuid =3D 0 > Panic occurred in module kernel loaded at 0xffffffff80200000: >=20 > Stack: -------------------------------------------------- > kernel:kassert_panic+0x166 > kernel:g_resize_provider_event+0x181 > kernel:g_run_events+0x186^M^M > kernel:fork_exit+0x83^M^M > -------------------------------------------------- >=20 > No further information available unfortunately. >=20 da13 at mps0 bus 0 scbus0 target 14 lun 0^M^M da13: s/n JPW9K0N00LSZYL detached^M^M (da24:mps0: mps0:0:Target 15 supports SSU^M^M 14:mps0: 0): Target 17 supports SSU^M^M UNMAPPED^M^M =2E.. g_access(969): provider da13 has error^M^M da24 at mps0 bus 0 scbus0 target 14 lun 0^M^M g_access(969): provider da13 has error^M^M da24: g_access(969): provider da13 has error^M^M da24: SCSI-6 device^M^= M da24: Serial Number JPW9K0N00LSZYL^M^M da24: 300.000MB/s transfers^M^M da24: Command Queueing enabled^M^M da24: 476940MB (976773168 512 byte sectors)^M^M da24: quirks=3D0x2^M^M (da13:da18 at mps0 bus 0 scbus0 target 12 lun 0^M^M mps0:0:da18: 14:0): s/n JPW9K0N00LT8ELremoving device entry^M^M detached^M^M (da13:da16 at mps0 bus 0 scbus0 target 13 lun 0^M^M mps0:0:da16: 14:0): s/n JPW9K0N00LTB4LPeriph destroyed^M^M detached^M^M da17 at mps0 bus 0 scbus0 target 10 lun 0^M^M da17: s/n JPW9K0N00JZESL detached^M^M da20 at mps0 bus 0 scbus0 target 16 lun 0^M^M da20: s/n JPW9K0N00K2PEL detached^M^M panic @ time 1470916206.652, thread 0xfffff8000412f000: g_resize_provider_event but withered^M^M =2E.. --=20 Regards, Bryan Drewery --17WHJ3RAvddNgIinO1Obf5qvVSbp4CkOE-- --2kcffhj5W2J6CgSSdv55iWKmGb5JENCdA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXrRh1AAoJEDXXcbtuRpfPW8QIAIa/XigCyeKPe6Wpum73+uKw GLqxb4oakDbiqQmJ51bT+zOl9j/mNHKltmbOWK7oj0E1Cbtb1vlb9RqkHrSK/+jI o17yodtPMkp7F1IfL3hui9E/75fbXilKAOMa78b40vOxNwlq6NcLhypv1KbFGezy JTr/WbmOZWveoUgVvFXci4h3uZLHy3JXDXuESxB8/AlTYidxFJBwt2uXp/7+G3Tb AGZabMd3li3ATihwQgTElBs/5Ig9pjAnYy2Oi/cT6KbMRe5e4HPeJ2L9vdaEaR7Z TehvhZ5RErZOo7QnJRB7pPROrw1+kYytk7IJWF4qrHRYu6SxY72svFlMd3vW1Zc= =wik5 -----END PGP SIGNATURE----- --2kcffhj5W2J6CgSSdv55iWKmGb5JENCdA--