Date: Wed, 1 Jun 2005 11:17:34 +0200 From: Maxime Henrion <mux@FreeBSD.org> To: delphij@delphij.net Cc: freebsd-arch@FreeBSD.org Subject: Re: [PATCH RFC] Add a macro for null mount options to sbin/mount* Message-ID: <20050601091734.GA14661@elvis.mu.org> In-Reply-To: <1117613456.771.16.camel@spirit> References: <1117613456.771.16.camel@spirit>
next in thread | previous in thread | raw e-mail | index | archive | help
Xin LI wrote:
> Hi, -arch@,
>
> In our mount* utilities, the null mount option, which is usually be used
> as a terminator of an option vector, is defined with some hand-rolled
> terms, e.g.: {NULL}, {NULL, 0, 0, 0}, etc.
>
> I think it would be nice to have a new macro to deal with this, say,
> MOPT_NULL, which would be extended to {NULL, 0, 0, 0}, which can act as
> an explicit initialize. And in my opinion, something like:
>
> %%%
> opt = {
> MOPT_STD,
> MOPT_NULL
> };
> %%%
>
> Looks better than:
>
> %%%
> opt = {
> MOPT_STD,
> { NULL }
> };
> %%%
>
> That has lead to the attached patchset. May I go ahead and commit it?
This is definitely nice. Please commit!
Cheers,
Maxime
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050601091734.GA14661>