From owner-freebsd-fs@FreeBSD.ORG  Fri Apr  2 07:10:07 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D7D94106566C
	for <freebsd-fs@freebsd.org>; Fri,  2 Apr 2010 07:10:07 +0000 (UTC)
	(envelope-from to.my.trociny@gmail.com)
Received: from mail-bw0-f216.google.com (mail-bw0-f216.google.com
	[209.85.218.216])
	by mx1.freebsd.org (Postfix) with ESMTP id 64F0F8FC16
	for <freebsd-fs@freebsd.org>; Fri,  2 Apr 2010 07:10:07 +0000 (UTC)
Received: by bwz8 with SMTP id 8so1412226bwz.3
	for <freebsd-fs@freebsd.org>; Fri, 02 Apr 2010 00:10:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:from:to:cc:subject
	:organization:date:message-id:user-agent:mime-version:content-type;
	bh=EKaahNnnDL7ITiPN3RsYxzrO2SdqnrCmIt/PM3XzK7E=;
	b=KXW9LXsXcLWQ0GkR4rec2kD4i67VLC3ZbcYkjhd4vrZ+U3wCbrSw1xWg0DHvA8bRE1
	C4Vw9A7yF96L2weV+B5oq0awMAKUu3juXnHL9p1lSB40HxP+76qK3HPtY2HfJwb+Fqja
	PZEmRhRwSiw34KsY1BliMs2zp94PcfWqdkLA4=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:to:cc:subject:organization:date:message-id:user-agent
	:mime-version:content-type;
	b=P3fzydiYzrgZw1rkzj73x/K7mxwg1BCzaqgzfMZdT6P3B5tHov0QiCwhjLFyl+o9a+
	tcRnhL9vhW3Hn0zbTwzJ9mz/utV0s2C4eazhu+cz2UkrH+SX1Q1b/7A1/cnfZP9dMkds
	y//YwBtdnTErMeUDoIiFjSaR5Gm5bXEx2e6jg=
Received: by 10.204.1.136 with SMTP id 8mr2685082bkf.92.1270192205644;
	Fri, 02 Apr 2010 00:10:05 -0700 (PDT)
Received: from localhost (ua1.etadirect.net [91.198.140.16])
	by mx.google.com with ESMTPS id 15sm4639928bwz.12.2010.04.02.00.10.04
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Fri, 02 Apr 2010 00:10:04 -0700 (PDT)
From: Mikolaj Golub <to.my.trociny@gmail.com>
To: freebsd-fs@FreeBSD.org
Organization: TOA Ukraine
Date: Fri, 02 Apr 2010 10:10:02 +0300
Message-ID: <86sk7e1gad.fsf@zhuzha.ua1>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Eugene Grosbein <eugen@grosbein.pp.ru>
Subject: Lock leakage on rename if vop->vop_rename is NULL (kern/107439)
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2010 07:10:07 -0000

Hi,

Could somebody look at kern/107439? Although the pr is closed the issue still
persists: if a file system does not provide vop_rename the vop_bypass() is
called and the vnods, which are expected to be unlocked in VOP_RENAME(), are
left locked.

I have attached there the patch that solves the problem but I am not confident
about the solution.

-- 
Mikolaj Golub