From owner-svn-src-head@freebsd.org Sat Apr 9 20:29:58 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9D57B0942E for ; Sat, 9 Apr 2016 20:29:58 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 426D51FB2 for ; Sat, 9 Apr 2016 20:29:58 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: by mail-wm0-x233.google.com with SMTP id l6so100786343wml.1 for ; Sat, 09 Apr 2016 13:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=fN6AB2l7OBI2SkBUjeg8R0OAlLq8UzUAkK0yiVJisHI=; b=t5e1tMEJUXKzgFEpAh6zu07CNcPw9gKX1eJgPzOqfqHMOkyRi53PFpViePt81cwFNT atbxCVAHiy0batX74PfTuLPgSk1Y1hGAf50a48i7hMiPB0a5qyjat30LlR3cHt4p25Wm iSIjqGgod5p6N7noA8tHzANqAceJoPOpNPX/SPDR9OAlb+osrfJKa3avIsSWgGa/1rGY 32Mwf+fPrcEc0vUgECZ4ZafhzIODgkZJGxM9bVGBSFmcG+lyq+viocH/FfQV/VODLl/M 3nO0c5UV7XZ5V+/np1kCOJHzmDqlJZkZosDwXEX/o1KUJoIUjebC0sXTXf7CI0n7Xjhs opcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=fN6AB2l7OBI2SkBUjeg8R0OAlLq8UzUAkK0yiVJisHI=; b=C6cx9M9DoDmTws/7HlqErWNOKlIByt6Ct1LDLubLEpXoxafJvRcFXA6/+6N7B/FZgE 8RveYf/de3X6qLbnl9iH0qC27lIEIKnM12izp7MgagWm+YR0+H7NV8iDUxoI3uT1OcAy jDIl7eAHtVmR1B8oEmC0YNpNM0Qw/ujif2UXAhlwHA/cG07UvimnGHOibZf2m4zFH7qA Oi5vY9+gd87zkAfLu/Zl9ofvspUourPdUH3CPxIwzA+EsqUDRgJUXRCKKsChkrZ0Azg8 NWbArfozlzRNb0P3NuJaI1ojJam+j3jrMjUv67uvGdf8UiAytEqpqyGX3ZWF0E2H6InL Vbbw== X-Gm-Message-State: AD7BkJIwU3lgsvyMFHlrWxkeRv4E4BOgoIyXj/IK9UJQO1zPgylr0XX9ZkNJ0byu8Dwbpuln X-Received: by 10.194.246.137 with SMTP id xw9mr17576975wjc.172.1460233796012; Sat, 09 Apr 2016 13:29:56 -0700 (PDT) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id w67sm9115985wmd.23.2016.04.09.13.29.55 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 09 Apr 2016 13:29:55 -0700 (PDT) Subject: Re: svn commit: r297762 - head/sys/dev/ichiic To: John Baldwin , svn-src-head@freebsd.org References: <201604092018.u39KIYf3096159@repo.freebsd.org> From: Steven Hartland Message-ID: <57096645.5060105@multiplay.co.uk> Date: Sat, 9 Apr 2016 21:29:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <201604092018.u39KIYf3096159@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Apr 2016 20:29:58 -0000 Hi John, it would be nice if the commit message clarified why the change was made, as well as what was changed. This would allow others like myself to learn about the reasons for changes like this, which aren't self explanatory. On 09/04/2016 21:18, John Baldwin wrote: > Author: jhb > Date: Sat Apr 9 20:18:34 2016 > New Revision: 297762 > URL: https://svnweb.freebsd.org/changeset/base/297762 > > Log: > Use DELAY() instead of sleeping during boot-time attach. > > Tested by: Wolfgang Zenker > > Modified: > head/sys/dev/ichiic/ig4_iic.c > > Modified: head/sys/dev/ichiic/ig4_iic.c > ============================================================================== > --- head/sys/dev/ichiic/ig4_iic.c Sat Apr 9 20:05:39 2016 (r297761) > +++ head/sys/dev/ichiic/ig4_iic.c Sat Apr 9 20:18:34 2016 (r297762) > @@ -117,7 +117,10 @@ set_controller(ig4iic_softc_t *sc, uint3 > error = 0; > break; > } > - mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1); > + if (cold) > + DELAY(1000); > + else > + mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1); > } > return (error); > } >