From owner-svn-src-head@FreeBSD.ORG Thu May 28 18:11:09 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D1EC61065675; Thu, 28 May 2009 18:11:09 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id BFBFD8FC13; Thu, 28 May 2009 18:11:09 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n4SIB9bu045679; Thu, 28 May 2009 18:11:09 GMT (envelope-from alc@svn.freebsd.org) Received: (from alc@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n4SIB9ip045676; Thu, 28 May 2009 18:11:09 GMT (envelope-from alc@svn.freebsd.org) Message-Id: <200905281811.n4SIB9ip045676@svn.freebsd.org> From: Alan Cox Date: Thu, 28 May 2009 18:11:09 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r192986 - in head/sys: fs/nfsclient fs/smbfs nfsclient X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2009 18:11:10 -0000 Author: alc Date: Thu May 28 18:11:09 2009 New Revision: 192986 URL: http://svn.freebsd.org/changeset/base/192986 Log: Make *getpages()s' assertion on the state of each page's dirty bits stricter. Modified: head/sys/fs/nfsclient/nfs_clbio.c head/sys/fs/smbfs/smbfs_io.c head/sys/nfsclient/nfs_bio.c Modified: head/sys/fs/nfsclient/nfs_clbio.c ============================================================================== --- head/sys/fs/nfsclient/nfs_clbio.c Thu May 28 17:36:44 2009 (r192985) +++ head/sys/fs/nfsclient/nfs_clbio.c Thu May 28 18:11:09 2009 (r192986) @@ -311,7 +311,7 @@ ncl_getpages(struct vop_getpages_args *a */ m->valid = 0; vm_page_set_valid(m, 0, size - toff); - KASSERT((m->dirty & vm_page_bits(0, size - toff)) == 0, + KASSERT(m->dirty == 0, ("nfs_getpages: page %p is dirty", m)); } else { /* Modified: head/sys/fs/smbfs/smbfs_io.c ============================================================================== --- head/sys/fs/smbfs/smbfs_io.c Thu May 28 17:36:44 2009 (r192985) +++ head/sys/fs/smbfs/smbfs_io.c Thu May 28 18:11:09 2009 (r192986) @@ -525,7 +525,7 @@ smbfs_getpages(ap) */ m->valid = 0; vm_page_set_valid(m, 0, size - toff); - KASSERT((m->dirty & vm_page_bits(0, size - toff)) == 0, + KASSERT(m->dirty == 0, ("smbfs_getpages: page %p is dirty", m)); } else { /* Modified: head/sys/nfsclient/nfs_bio.c ============================================================================== --- head/sys/nfsclient/nfs_bio.c Thu May 28 17:36:44 2009 (r192985) +++ head/sys/nfsclient/nfs_bio.c Thu May 28 18:11:09 2009 (r192986) @@ -214,7 +214,7 @@ nfs_getpages(struct vop_getpages_args *a */ m->valid = 0; vm_page_set_valid(m, 0, size - toff); - KASSERT((m->dirty & vm_page_bits(0, size - toff)) == 0, + KASSERT(m->dirty == 0, ("nfs_getpages: page %p is dirty", m)); } else { /*