From owner-freebsd-hackers@freebsd.org  Tue Feb  2 13:17:27 2016
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 532F4A97936
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Tue,  2 Feb 2016 13:17:27 +0000 (UTC) (envelope-from slw@zxy.spb.ru)
Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 116C738C;
 Tue,  2 Feb 2016 13:17:27 +0000 (UTC) (envelope-from slw@zxy.spb.ru)
Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD))
 (envelope-from <slw@zxy.spb.ru>)
 id 1aQapZ-000EMz-5F; Tue, 02 Feb 2016 16:17:17 +0300
Date: Tue, 2 Feb 2016 16:17:17 +0300
From: Slawa Olhovchenkov <slw@zxy.spb.ru>
To: Konstantin Belousov <kib@freebsd.org>
Cc: Mateusz Guzik <mjguzik@gmail.com>, freebsd-hackers@freebsd.org,
 Mateusz Guzik <mjg@freebsd.org>
Subject: Re: [PATCH 1/2] fork: pass arguments to fork1 in a dedicated structure
Message-ID: <20160202131717.GO88527@zxy.spb.ru>
References: <20160201103632.GL91220@kib.kiev.ua>
 <1454386069-29657-1-git-send-email-mjguzik@gmail.com>
 <1454386069-29657-2-git-send-email-mjguzik@gmail.com>
 <20160202131145.GT91220@kib.kiev.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160202131145.GT91220@kib.kiev.ua>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: slw@zxy.spb.ru
X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Feb 2016 13:17:27 -0000

On Tue, Feb 02, 2016 at 03:11:45PM +0200, Konstantin Belousov wrote:

> On Tue, Feb 02, 2016 at 05:07:48AM +0100, Mateusz Guzik wrote:
> > From: Mateusz Guzik <mjg@freebsd.org>
> > 
> > ---
> >  sys/compat/cloudabi/cloudabi_proc.c |  7 +++++-
> >  sys/compat/linux/linux_fork.c       | 17 ++++++++++----
> >  sys/kern/init_main.c                |  6 +++--
> >  sys/kern/kern_fork.c                | 46 +++++++++++++++++++++++++------------
> >  sys/kern/kern_kthread.c             |  7 ++++--
> >  sys/sys/proc.h                      | 12 ++++++++--
> >  6 files changed, 68 insertions(+), 27 deletions(-)
> > 
> > diff --git a/sys/compat/cloudabi/cloudabi_proc.c b/sys/compat/cloudabi/cloudabi_proc.c
> > index d917337..010efca 100644
> > --- a/sys/compat/cloudabi/cloudabi_proc.c
> > +++ b/sys/compat/cloudabi/cloudabi_proc.c
> > @@ -75,12 +75,17 @@ int
> >  cloudabi_sys_proc_fork(struct thread *td,
> >      struct cloudabi_sys_proc_fork_args *uap)
> >  {
> > +	struct fork_req fr = {};
> >  	struct filecaps fcaps = {};
> >  	struct proc *p2;
> >  	int error, fd;
> >  
> >  	cap_rights_init(&fcaps.fc_rights, CAP_FSTAT, CAP_EVENT);
> > -	error = fork1(td, RFFDG | RFPROC | RFPROCDESC, 0, &p2, &fd, 0, &fcaps);
> > +	fr.fr_flags = RFFDG | RFPROC | RFPROCDESC;
> > +	fr.fr_procp = &p2;
> > +	fr.fr_pd_fd = &fd;
> > +	fr.fr_pd_fcaps = &fcaps;
> > +	error = fork1(td, &fr);
> >  	if (error != 0)
> >  		return (error);
> The patch is fine.
> 
> Would be great to not use initializer in declaration, i.e. use bzero()
> instead of c99 designated initializers.

What purpose?
Compiler may use more effecien zeroing with c99 designated initializers.