From nobody Tue Jun 30 13:10:34 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gqNmp73mTz6kBJ0 for ; Tue, 30 Jun 2026 13:10:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gqNmp49Q2z3G6x for ; Tue, 30 Jun 2026 13:10:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782825034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aHYlufVTxtoD6NOiqshqCYMLLONODzjj52utgFDlgQQ=; b=jmm/9qvt1JoRB6bsE2o1n/a94t2SOEk0wum+c/lGfVWd9KfjSS1b0u8CUe5byl5PnmOj1k 1ki2S7cJrg4Doq/NnkcF7HJilkaQ7/ovAbOmpXhuqspeRTdLX3py4BREcR6IzzvtJ+Nynl X2oaMsexu8iq+yvt6nhsChBoO0Y55WNAwv9VWvvYzhE5We/8AlZSIF3W2FucUodvDOKKRn K+QHif8oINCgrR/e/IEiCd6870ngJawCY+Yra5If4N8dzomhLRZsF8EMYoeANcs220kf0a rh5YP0xzGF+lCmx/TkSvM9T5qQ6qImxfka2dgQsAmo18y7S0Yr6rrojhyB6zag== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782825034; a=rsa-sha256; cv=none; b=MYtMtYY0Z9UUqd+FUVYJzapw72sKdYR5MfZxZrpdsiGKOfjp0iszEep5pDJKH/ym8uYsXI Jrzv9d+yu5ZJehLHm8f/wDOrFk2xoQb+LsXbdI8X5z2eklPUhZyipKxdNwkN4A9kkU7a9o 48f6tFXKS5gQtw37c5u2jErVyZPWzE08tWSM4qAy6Y10F0iB72gC8M9DzAyj/ZceUTX7Bt xxcSIdn8lmdB4LBF7stdQH84j2Fy8SG68soL1xqFMgM62U3ZFRofejALHR8BJVTTHcBcTb d759kMKWxd8igfkYKAWBo6dTNUHPiQZAKPR6s5fDAtsjwiG2SqpdI5XHVnqMJQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782825034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aHYlufVTxtoD6NOiqshqCYMLLONODzjj52utgFDlgQQ=; b=W+MsR6kyW75bkgSah4+HrIdmwsF2Urf9J9UAa+6x0bsobFxPDU/EKL0DVKrshuTDzqw7Ec u3lK1Ha/hb8pWRb1rdyrElD3+fCKjy59Y6zKuM/g6uFo3YpgWetKtt14vdhFjAJf/B5EST PAuUMG9lKGRtyTUYWO7/c9NgktMECyOwFyuHX5UgIG9tAmjSq4o4oTXUU1uE4thIoc38e9 rXBcrG5jq59+vclGYBMcBnHcN+do8URxtiEMpfuoRiTv3xrRIAxhm/EgAQwdqF8Oa4m6BS wSgcHLB5ny7iezZ4b4cI9q316NRMxPdV3sJsuAgd0GwBG8J6r/Gn924k6YPUOw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gqNmp36YkzkxW for ; Tue, 30 Jun 2026 13:10:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 232ea by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 30 Jun 2026 13:10:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Siva Mahadevan Subject: git: f7f916d755fe - main - ping: Fix bell char ordering in -A test cases List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: siva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f7f916d755fe5b48a2a68a937beea770b7bafa95 Auto-Submitted: auto-generated Date: Tue, 30 Jun 2026 13:10:34 +0000 Message-Id: <6a43c04a.232ea.737b86a6@gitrepo.freebsd.org> The branch main has been updated by siva: URL: https://cgit.FreeBSD.org/src/commit/?id=f7f916d755fe5b48a2a68a937beea770b7bafa95 commit f7f916d755fe5b48a2a68a937beea770b7bafa95 Author: Siva Mahadevan AuthorDate: 2026-06-26 12:22:57 +0000 Commit: Siva Mahadevan CommitDate: 2026-06-30 13:07:59 +0000 ping: Fix bell char ordering in -A test cases Previously, these tests expected the bell chars to arrive before the initial status line. This appeared to be ok because ping(8) incorrectly mixed unbuffered and buffered writes by using printf(3) calls for the initial status, but direct write(2) calls for the bell chars. 141bb85798 revealed that the test's assertions only passed because the buffered writes did not get flushed before the direct writes in the test runs. 8bda488114f3 fixed ping(8) to use POSIX stdio buffered writes in all cases and guarantee a deterministic output ordering to stdout observers. This patch fixes the test to match the correct ordering. Reviewed by: des Sponsored by: The FreeBSD Foundation --- sbin/ping/tests/test_ping.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sbin/ping/tests/test_ping.py b/sbin/ping/tests/test_ping.py index fdf9c875329c..88164c2ab816 100644 --- a/sbin/ping/tests/test_ping.py +++ b/sbin/ping/tests/test_ping.py @@ -431,8 +431,8 @@ round-trip min/avg/max/stddev = /// ms "args": "ping -A -c3 192.0.2.2", "returncode": 2, "stdout": """\ -\x07\x07PING 192.0.2.2 (192.0.2.2): 56 data bytes - +PING 192.0.2.2 (192.0.2.2): 56 data bytes +\x07\x07 --- 192.0.2.2 ping statistics --- 3 packets transmitted, 0 packets received, 100.0% packet loss """, @@ -463,8 +463,8 @@ round-trip min/avg/max/stddev = /// ms "args": "ping -A -c3 2001:db8::2", "returncode": 2, "stdout": """\ -\x07\x07PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2 - +PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2 +\x07\x07 --- 2001:db8::2 ping statistics --- 3 packets transmitted, 0 packets received, 100.0% packet loss """,