From owner-svn-ports-all@freebsd.org Mon Jan 6 22:49:42 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 390161F9027; Mon, 6 Jan 2020 22:49:42 +0000 (UTC) (envelope-from ler@FreeBSD.org) Received: from thebighonker.lerctr.org (ns-b.lerctr.org [IPv6:2001:470:1f0f:3ad::53:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "*.lerctr.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47s9gV0qtLz4MKV; Mon, 6 Jan 2020 22:49:41 +0000 (UTC) (envelope-from ler@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=ler2019; h=Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: Content-Transfer-Encoding:Content-Type:MIME-Version:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UN0dHyUqiQnGbYnmE1RLEh3q+DwN9AcXgXgdVweWrmg=; b=iOzif67TsNPA2Idd/6aVfCj7Ra 6NpdA8e+lKKY4b0e9a7iCfyiB8SaFr+GRLhnVAYM63JnGd7sL4tkR9CXHVnvYNF21Ts2PhUz5a0eQ OiKi6oUqS5FDJHue2DiR64bE4WuNe96ef9cXB7tm2GPk2fjHVfzq4demh/9jEvlJOB1nDMxL+/2tK UvX4Lt5RkMh8UcuCS5TsiezuhCyKUnkjpyZE4C3J/zYYjSDMxoBIBfu9kFAsbs70YoA2PYMcEwqk4 p9rYD2HFJfV8mlBwP5qCZGdoHBT739u+KtlWn0V2HBynUcOoBFeI+wOWeN4Xbxt1wcbc25lQROte+ 1TSoVSlA==; Received: from thebighonker.lerctr.org ([2001:470:1f0f:3ad:bb:dcff:fe50:d900]:46008 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1iobBp-000151-8M; Mon, 06 Jan 2020 16:49:37 -0600 Received: from 2600:1700:210:b180:75e2:77b0:2242:c0b by webmail.lerctr.org with HTTP (HTTP/1.1 POST); Mon, 06 Jan 2020 16:49:37 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 06 Jan 2020 16:49:37 -0600 From: Larry Rosenman To: Mathieu Arnold Cc: Adam Weinberger , Cy Schubert , ports-committers , svn-ports-all , svn-ports-head Subject: Re: svn commit: r522273 - in head/sysutils/lsof: . files In-Reply-To: <20200106224656.wefyervptxppm4pv@atuin.in.mat.cc> References: <202001062042.006Kg81F048249@repo.freebsd.org> <202001062102.006L2KrM089339@slippy.cwsent.com> <20200106224656.wefyervptxppm4pv@atuin.in.mat.cc> User-Agent: Roundcube Webmail/1.4.1 Message-ID: <77126b0704f82ceb1890e4570fd7b1f5@FreeBSD.org> X-Sender: ler@FreeBSD.org X-Rspamd-Queue-Id: 47s9gV0qtLz4MKV X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.995,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; REPLY(-4.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jan 2020 22:49:42 -0000 On 01/06/2020 4:46 pm, Mathieu Arnold wrote: > On Mon, Jan 06, 2020 at 02:19:58PM -0700, Adam Weinberger wrote: >> On Mon, Jan 6, 2020 at 2:05 PM Larry Rosenman wrote: >> > >> > On 01/06/2020 3:02 pm, Cy Schubert wrote: >> > > In message <202001062042.006Kg81F048249@repo.freebsd.org>, Larry >> > > Rosenman >> > > write >> > > s: >> > >> Author: ler >> > >> Date: Mon Jan 6 20:42:08 2020 >> > >> New Revision: 522273 >> > >> URL: https://svnweb.freebsd.org/changeset/ports/522273 >> > >> >> > >> Log: >> > >> sysutils/lsof: fix build following base r356337. >> > >> >> > >> I took the patch from 243122 as it was more correct. >> > >> >> > >> PR: 243122, 243083 >> > >> Submitted by: cy, yasu@utahime.org >> > >> >> > >> Added: >> > >> head/sysutils/lsof/files/patch-dialects_freebsd_dnode2.c >> > >> (contents, props >> > >> changed) >> > >> Modified: >> > >> head/sysutils/lsof/Makefile >> > >> >> > >> Modified: head/sysutils/lsof/Makefile >> > >> ============================================================================= >> > >> = >> > >> --- head/sysutils/lsof/Makefile Mon Jan 6 20:25:36 2020 (r52227 >> > >> 2) >> > >> +++ head/sysutils/lsof/Makefile Mon Jan 6 20:42:08 2020 (r52227 >> > >> 3) >> > >> @@ -3,7 +3,7 @@ >> > >> >> > >> PORTNAME= lsof >> > >> DISTVERSION= 4.93.2 >> > >> -PORTREVISION= 6 >> > >> +PORTREVISION= 8 >> > > >> > > Was this needed? The package doesn't change, only fixing the build. >> > > >> > >> PORTEPOCH= 8 >> > >> CATEGORIES= sysutils >> > >> >> > >> >> > >> > I thought build breaks on the cluster needed a port rev bump... >> >> The logic is that if the currently-built package needs to change, it >> requires a bump. If there is no currently-built package because of a >> build failure, a bump doesn't have a meaningful effect. > > Said in another way, PORTREVISION bumps happen when an existing > package, > 4.93.2_6 here, has issues (mostly runtime, but can be other reasons, > see > the PHB for full list) and it needs to be upgraded to a newer version > to > work correctly, 4.93.2_8 here. > > If 4.93.2_6 never existed because it could not be built, well, the most > anybody ever had was 4.93.2_5, and once 4.93.2_6 finally builds, it > will > get updated correctly. It did build, then -CURRENT /usr/src changed out from under it and it broke. I think the PORTREVISION bump here was corret. -- Larry Rosenman http://people.freebsd.org/~ler Phone: +1 214-642-9640 E-Mail: ler@FreeBSD.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106