Date: Fri, 19 Feb 2016 11:52:01 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 207299] print/muttprint: Update to 0.73 Message-ID: <bug-207299-13-dZFD4XR7AI@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-207299-13@https.bugs.freebsd.org/bugzilla/> References: <bug-207299-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207299 --- Comment #8 from Raphael Kubo da Costa <rakuco@FreeBSD.org> --- Questions I have about the patch: - Can't you avoid patching Makefile.am if you just install the additional documentation files yourself in the post-install target? - Why are the translated man pages not being installed? - Does doc/manpages/en/muttprint.pod as-is cause build issues? - Is installing the original files listed in pics/Makefile.am a problem? If not, you could get rid of the patch and just install Beastie.eps in post-install. And something to consider but not exactly urgent: - You should convert checks for certain options to options helpers. For example: .if ${PORT_OPTIONS:MX11} RUN_DEPENDS+=3D convert:${PORTSDIR}/graphics/ImageMagick .else RUN_DEPENDS+=3D convert:${PORTSDIR}/graphics/ImageMagick-nox11 .endif becomes X11_RUN_DEPENDS=3Dconvert:${PORTSDIR}/graphics/ImageMagick X11_RUN_DEPENDS_OFF=3Dconvert:${PORTSDIR}/graphics/ImageMagick-nox11 - The same applies to options helpers in targets. Fore xample: post-patch: # ... .if ${PORT_OPTIONS:MCUPS} @${REINPLACE_CMD} 's|lpr $$CUPS_OPTIONS|${PREFIX}/bin/lpr $$CUPS_OPTION= S|' ${WRKSRC}/muttprint .endif becomes post-patch-CUPS-on: @${REINPLACE_CMD} 's|lpr $$CUPS_OPTIONS|${PREFIX}/bin/lpr $$CUPS_OPTION= S|' ${WRKSRC}/muttprint --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-207299-13-dZFD4XR7AI>