From owner-freebsd-threads@FreeBSD.ORG  Sat Oct 30 22:05:24 2004
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from [IPv6:::1] (hub.freebsd.org [216.136.204.18])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4789416A4CE; Sat, 30 Oct 2004 22:05:23 +0000 (GMT)
Message-ID: <41840FB3.2020305@freebsd.org>
Date: Sat, 30 Oct 2004 16:03:31 -0600
From: Scott Long <scottl@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Julian Elischer <julian@elischer.org>
References: <Pine.GSO.4.43.0410281908000.5783-100000@sea.ntplx.net>
	<41817EE4.9080302@elischer.org>
In-Reply-To: <41817EE4.9080302@elischer.org>
X-Enigmail-Version: 0.86.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: Daniel Eischen <deischen@freebsd.org>
cc: threads@freebsd.org
cc: re@freebsd.org
cc: David Xu <davidxu@freebsd.org>
cc: John Baldwin <jhb@freebsd.org>
Subject: Re: MFC req for 5.x/5.3
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Oct 2004 22:05:25 -0000

Julian Elischer wrote:
> 
> 
> Daniel Eischen wrote:
> 
>> On Thu, 28 Oct 2004, Julian Elischer wrote:
>>
>>  
>>
>>> David Xu wrote:
>>>
>>>   
>>>
>>>> Here is the cvs log:
>>>>
>>>> Revision  Changes    Path
>>>>  1.58      +1 -0      src/lib/libpthread/thread/thr_create.c
>>>>  1.14      +1 -1      src/lib/libpthread/thread/thr_find_thread.c
>>>>  1.115     +27 -10    src/lib/libpthread/thread/thr_kern.c
>>>>  1.119     +15 -11    src/lib/libpthread/thread/thr_private.h
>>>>  1.81      +1 -2      src/lib/libpthread/thread/thr_sig.c
>>>>     
>>>
>>> commit message was:
>>> 1. Move thread list flags into new separate member, and atomically
>>>   put DEAD thread on GC list, this closes a race between pthread_join
>>>   and thr_cleanup.
>>> 2. Introduce a mutex to protect tcb initialization, tls allocation and
>>>   deallocation code in rtld seems no lock protection or it is broken,
>>>   under stress testing, memory is corrupted.
>>>
>>>
>>> translates to:
>>>
> 
> [diff removed]
> 
>>>   
>>
>>
>> Yes, these look right.
>>
>>  
>>
> 

Julian and all,

I know that re@ approved these a few days ago, but we haven't seen any 
acticity and we need to get RC2 out so that SACK can get validated and
we can turn to -RELEASE.  I know it's very short notice, but I'm going
to retract this MFC approval and instead ask that you only commit it to
RELENG_5.

Scott