Date: Sat, 30 Oct 2004 16:03:31 -0600 From: Scott Long <scottl@freebsd.org> To: Julian Elischer <julian@elischer.org> Cc: John Baldwin <jhb@freebsd.org> Subject: Re: MFC req for 5.x/5.3 Message-ID: <41840FB3.2020305@freebsd.org> In-Reply-To: <41817EE4.9080302@elischer.org> References: <Pine.GSO.4.43.0410281908000.5783-100000@sea.ntplx.net> <41817EE4.9080302@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer wrote: > > > Daniel Eischen wrote: > >> On Thu, 28 Oct 2004, Julian Elischer wrote: >> >> >> >>> David Xu wrote: >>> >>> >>> >>>> Here is the cvs log: >>>> >>>> Revision Changes Path >>>> 1.58 +1 -0 src/lib/libpthread/thread/thr_create.c >>>> 1.14 +1 -1 src/lib/libpthread/thread/thr_find_thread.c >>>> 1.115 +27 -10 src/lib/libpthread/thread/thr_kern.c >>>> 1.119 +15 -11 src/lib/libpthread/thread/thr_private.h >>>> 1.81 +1 -2 src/lib/libpthread/thread/thr_sig.c >>>> >>> >>> commit message was: >>> 1. Move thread list flags into new separate member, and atomically >>> put DEAD thread on GC list, this closes a race between pthread_join >>> and thr_cleanup. >>> 2. Introduce a mutex to protect tcb initialization, tls allocation and >>> deallocation code in rtld seems no lock protection or it is broken, >>> under stress testing, memory is corrupted. >>> >>> >>> translates to: >>> > > [diff removed] > >>> >> >> >> Yes, these look right. >> >> >> > Julian and all, I know that re@ approved these a few days ago, but we haven't seen any acticity and we need to get RC2 out so that SACK can get validated and we can turn to -RELEASE. I know it's very short notice, but I'm going to retract this MFC approval and instead ask that you only commit it to RELENG_5. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41840FB3.2020305>