Date: Sat, 5 Dec 2009 10:21:42 +0100 (CET) From: olli hauer <ohauer@gmx.de> To: FreeBSD-gnats-submit@FreeBSD.org, miwi@FreeBSD.org Cc: ohauer@gmx.de Subject: ports/141186: [patch] port ports-mgmt/tinderbox add missing option LSOF Message-ID: <20091205092142.E235B2614B@u18-124.dsl.vianetworks.de> Resent-Message-ID: <200912050930.nB59U2lE014728@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 141186
>Category: ports
>Synopsis: [patch] port ports-mgmt/tinderbox add missing option LSOF
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Sat Dec 05 09:30:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: olli hauer <ohauer@gmx.de>
>Release:
>Organization:
>Environment:
>Description:
The tinderbox port is missing the option for lsof from tinderbox-devel.
This feature is usefull if tinderbox runs with nullfs mounts.
>How-To-Repeat:
>Fix:
--- patch_tinderbox-3.3.txt begins here ---
--- Makefile
+++ Makefile
@@ -23,7 +23,8 @@
WEBUI "Install web interface" On \
APACHE "Use Apache for web interface" On \
LIGHTTPD "Use LightHTTPD for web interface" Off \
- CHECK_FOR_ROOT "Check it ./tc is run by uid 0" On
+ CHECK_FOR_ROOT "Check if ./tc is run by uid 0" On \
+ LSOF "For killMountProcesses() when using nullfs" On
NO_BUILD= yes
WANT_PERL= yes
@@ -83,6 +84,10 @@
RUN_DEPENDS+= lighttpd:${PORTSDIR}/www/lighttpd
.endif
+.if defined(WITH_LSOF)
+RUN_DEPENDS+= lsof:${PORTSDIR}/sysutils/lsof
+.endif
+
pre-everything::
.if (!defined(WITHOUT_APACHE) || defined(WITH_LIGHTTPD)) && !defined(WITH_WEBUI)
@${ECHO_CMD} "It doesn't make sense to depend on Apache or LightHTTPD if not using either web interface."
@@ -97,7 +102,7 @@
post-patch:
.ifdef WITHOUT_CHECK_FOR_ROOT
${REINPLACE_CMD} -e 's/^if \[ `id -u` != 0 \]; then/if false; then/' \
- ${WRKSRC}/tc
+ ${WRKSRC}/tc
.endif
@cd ${WRKSRC} && ${FIND} -E . -regex '.*(orig|bak)' -exec ${RM} {} \;
--- patch_tinderbox-3.3.txt ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091205092142.E235B2614B>