From owner-cvs-src@FreeBSD.ORG  Wed Feb  4 09:42:44 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4537C16A4CE; Wed,  4 Feb 2004 09:42:44 -0800 (PST)
Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 65F5743D48; Wed,  4 Feb 2004 09:42:42 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au
	[61.8.0.86])i14HgfLE012808;	Thu, 5 Feb 2004 04:42:41 +1100
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	i14Hgdt4024682;	Thu, 5 Feb 2004 04:42:39 +1100
Date: Thu, 5 Feb 2004 04:42:38 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Ruslan Ermilov <ru@FreeBSD.org>
In-Reply-To: <20040204163157.GC5546@FreeBSD.org.ua>
Message-ID: <20040205042752.D3649@gamplex.bde.org>
References: <200402041418.i14EIMfv054158@repoman.freebsd.org>
 <20040204163157.GC5546@FreeBSD.org.ua>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Bruce Evans <bde@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys sx.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Feb 2004 17:42:44 -0000

On Wed, 4 Feb 2004, Ruslan Ermilov wrote:

> On Wed, Feb 04, 2004 at 06:18:21AM -0800, Bruce Evans wrote:
> > bde         2004/02/04 06:18:21 PST
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/sys              sx.h
> >   Log:
> >   Include <sys/queue.h> before <sys/_lock.h> instead of depending on
> >   namespace pollution in other headers.  <sys/types.h> is now the only
> >   prerequisite for <sys/sx.h>.
> > ...
> Please update the sx(9) manpage to reflect this change.

That's easy since the reflection is null :-).  <sys/queue.h> isn't mentioned
in the man page.  Folloing the man page gave it as a side effect of
including <sys/lock.h>.

The man page is not incorrect in requiring <sys/param.h> and <sys/lock.h>
before <sys/sx.h>.  <sys/param.h> instead of <sys/types.h> is required
(for other headers) in practice, and <sys/lock.h> is required if
INVARIANTS is defined and sx_assert() is used.  It's easier to document
<sys/lock.h> as a prerequisite than to document the ifdef tangle.
<sys/mutex.h> enforces a prerequisite of <sys/lock.h> although it could
be unnecessary in similar cases.

Bruce