From owner-cvs-src-old@FreeBSD.ORG Tue Jan 4 19:32:31 2011 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 62E571065695 for ; Tue, 4 Jan 2011 19:32:31 +0000 (UTC) (envelope-from jmallett@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 513FC8FC0C for ; Tue, 4 Jan 2011 19:32:31 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id p04JWV2b064850 for ; Tue, 4 Jan 2011 19:32:31 GMT (envelope-from jmallett@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id p04JWV1X064849 for cvs-src-old@freebsd.org; Tue, 4 Jan 2011 19:32:31 GMT (envelope-from jmallett@repoman.freebsd.org) Message-Id: <201101041932.p04JWV1X064849@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to jmallett@repoman.freebsd.org using -f From: Juli Mallett Date: Tue, 4 Jan 2011 19:32:03 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/mips/include cpufunc.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2011 19:32:31 -0000 jmallett 2011-01-04 19:32:03 UTC FreeBSD src repository Modified files: sys/mips/include cpufunc.h Log: SVN rev 216972 on 2011-01-04 19:32:03Z by jmallett Correct an 8-year-old typo which reliably leads to typo after typo today: The macros here for generating coprocessor 0 accessors are named like: MIPS_RDRW32_COP0 That macro would produce mips_rd_() and mips_wr_() inlines to access the specified register by name from C. The problem is that the R and the W were swapped in the macros originally; it was meant to be named RDWR because it generated mips_rd_* and mips_wr_* functions, but was instead spelled RDRW, which nobody should be expected to get right by anything other than copy and paste. It's too many consonants in a row to keep straight anyway, so just prefer e.g.: MIPS_RW32_COP0 While here, add a missing #undef. Revision Changes Path 1.11 +42 -41 src/sys/mips/include/cpufunc.h