Date: Tue, 4 Jan 2011 19:32:03 +0000 (UTC) From: Juli Mallett <jmallett@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/mips/include cpufunc.h Message-ID: <201101041932.p04JWV1X064849@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jmallett 2011-01-04 19:32:03 UTC
FreeBSD src repository
Modified files:
sys/mips/include cpufunc.h
Log:
SVN rev 216972 on 2011-01-04 19:32:03Z by jmallett
Correct an 8-year-old typo which reliably leads to typo after typo today:
The macros here for generating coprocessor 0 accessors are named like:
MIPS_RDRW32_COP0
That macro would produce mips_rd_<register>() and mips_wr_<register>()
inlines to access the specified register by name from C. The problem is that
the R and the W were swapped in the macros originally; it was meant to be named
RDWR because it generated mips_rd_* and mips_wr_* functions, but was instead
spelled RDRW, which nobody should be expected to get right by anything other
than copy and paste.
It's too many consonants in a row to keep straight anyway, so just prefer e.g.:
MIPS_RW32_COP0
While here, add a missing #undef.
Revision Changes Path
1.11 +42 -41 src/sys/mips/include/cpufunc.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101041932.p04JWV1X064849>