From owner-freebsd-current Tue Mar 11 10:22:53 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA26990 for current-outgoing; Tue, 11 Mar 1997 10:22:53 -0800 (PST) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id KAA26974 for ; Tue, 11 Mar 1997 10:22:46 -0800 (PST) Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id TAA03800 for current@freebsd.org; Tue, 11 Mar 1997 19:22:39 +0100 Received: (from j@localhost) by uriah.heep.sax.de (8.8.5/8.8.5) id TAA01299; Tue, 11 Mar 1997 19:12:11 +0100 (MET) Message-ID: <19970311191211.UO03451@uriah.heep.sax.de> Date: Tue, 11 Mar 1997 19:12:11 +0100 From: j@uriah.heep.sax.de (J Wunsch) To: current@freebsd.org Subject: Re: ppp References: <199703111513.CAA17912@godzilla.zeta.org.au> X-Mailer: Mutt 0.60_p2-3,5,8-9 Mime-Version: 1.0 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: ; from ??????????????? on Mar 11, 1997 18:41:59 +0300 Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk As Andrey wrote: > PPP code was written in assumptions that SIGALRM reaction > is not delayed, so if we trust developer, he choose timeout + handler > action in the way that signals not missed. The PPP developer however did *way* too many things inside his signal handlers. Remember, signal handlers are not running in normal process context. It's always a good idea to restrict your doing inside the handler to the absolutely necessary minimum. Sending packets and shuffling large amounts of data does certainly not belong to this category. This PPP state machine would probably benefit from a multithreaded implementation. I'm afraid the FreeBSD camp lacks enough clueful developers for such an implementation, however. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)