From owner-freebsd-python@freebsd.org Thu Feb 18 16:37:42 2021 Return-Path: Delivered-To: freebsd-python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 52E5153F078 for ; Thu, 18 Feb 2021 16:37:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DhL3V1RL5z4nD8 for ; Thu, 18 Feb 2021 16:37:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 2EA7253F0D9; Thu, 18 Feb 2021 16:37:42 +0000 (UTC) Delivered-To: python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2E66F53F334 for ; Thu, 18 Feb 2021 16:37:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DhL3V0YNjz4nD7 for ; Thu, 18 Feb 2021 16:37:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 051941B763 for ; Thu, 18 Feb 2021 16:37:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11IGbfI1097753 for ; Thu, 18 Feb 2021 16:37:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11IGbfKS097752 for python@FreeBSD.org; Thu, 18 Feb 2021 16:37:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 253604] lang/python39: use libmpdec from ports Date: Thu, 18 Feb 2021 16:37:42 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: skrah@bytereef.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2021 16:37:42 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253604 --- Comment #2 from Stefan Krah --- I didn't notice that you had already opened an issue, sorry. The _decimal.c changes are generally required because the mpdecimal.h header has been cleaned up. There were some leftovers like the typedef of "uchar", which collided with some system header on Solaris and broke the build. It does not build here without the patch: In file included from ./Include/unicodeobject.h:58, from ./Include/Python.h:97, from /usr/home/stefan/Python-3.9.1/Modules/_decimal/_decimal.c:29: /usr/home/stefan/Python-3.9.1/Modules/_decimal/_decimal.c: In function 'dec_format': /usr/home/stefan/Python-3.9.1/Modules/_decimal/_decimal.c:3283:43: error: 'uchar' undeclared (first use in this function); did you mean 'u_char'? 3283 | if (n > 1 || (n =3D=3D 1 && !isascii((uchar)spec.dot[0]))) { | ^~~~~ Would you like to close this and continue with your original issue or keep = this one open? --=20 You are receiving this mail because: You are the assignee for the bug.=