From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Nov 14 17:50:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AC21E57A for ; Thu, 14 Nov 2013 17:50:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8C42F2F2F for ; Thu, 14 Nov 2013 17:50:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rAEHo0Eq077956 for ; Thu, 14 Nov 2013 17:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rAEHo02I077955; Thu, 14 Nov 2013 17:50:00 GMT (envelope-from gnats) Resent-Date: Thu, 14 Nov 2013 17:50:00 GMT Resent-Message-Id: <201311141750.rAEHo02I077955@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dominic Fandrey Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 72FDB389 for ; Thu, 14 Nov 2013 17:47:02 +0000 (UTC) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 620C12F01 for ; Thu, 14 Nov 2013 17:47:02 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id rAEHl1k0024939 for ; Thu, 14 Nov 2013 17:47:02 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id rAEHl1ox024938; Thu, 14 Nov 2013 17:47:01 GMT (envelope-from nobody) Message-Id: <201311141747.rAEHl1ox024938@oldred.freebsd.org> Date: Thu, 14 Nov 2013 17:47:01 GMT From: Dominic Fandrey To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/183959: [maintainer-update] games/ioquake3 games/ioquake3-server X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2013 17:50:00 -0000 >Number: 183959 >Category: ports >Synopsis: [maintainer-update] games/ioquake3 games/ioquake3-server >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Thu Nov 14 17:50:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Dominic Fandrey >Release: stable/10 >Organization: private >Environment: FreeBSD mobileKamikaze.norad 10.0-BETA3 FreeBSD 10.0-BETA3 #0 r257904: Sun Nov 10 02:09:34 CET 2013 root@mobileKamikaze.norad:/usr/obj/HP6510b-10/amd64/usr/src/sys/HP6510b-10 amd64 >Description: games/ioquake3 and games/ioquake3-server do not build on i386 due to clang variable scope issues in combination with inline assembler. >How-To-Repeat: # cd /usr/ports/games/ioquake3 # make ARCH=i386 >Fix: The proposed fix simply renders the offending static variable global. This is bad style, but can be done safely, because there are no extern declarations referring to it. Patch attached with submission follows: Index: games/ioquake3/files/patch-code-qcommon-vm_x86.c =================================================================== --- games/ioquake3/files/patch-code-qcommon-vm_x86.c (revision 333755) +++ games/ioquake3/files/patch-code-qcommon-vm_x86.c (working copy) @@ -1,5 +1,5 @@ --- code/qcommon/vm_x86.c.orig 2008-08-18 01:22:06.000000000 +0200 -+++ code/qcommon/vm_x86.c 2010-11-27 14:01:33.000000000 +0100 ++++ code/qcommon/vm_x86.c 2013-11-14 11:44:27.000000000 +0100 @@ -36,7 +36,25 @@ /* need this on NX enabled systems (i386 with PAE kernel or @@ -27,3 +27,15 @@ #define VM_X86_MMAP #endif +@@ -90,7 +108,11 @@ + static void (*const asmCallPtr)(void) = AsmCall; + + ++#ifdef __clang__ ++ int callMask = 0; ++#else + static int callMask = 0; ++#endif + + static int instruction, pass; + static int lastConst = 0; >Release-Note: >Audit-Trail: >Unformatted: