From owner-freebsd-current@FreeBSD.ORG Wed Oct 18 11:35:23 2006 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E024F16A47B for ; Wed, 18 Oct 2006 11:35:22 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-0-0-cust107.cdif.cable.ntl.com [81.104.168.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A8AD43D45 for ; Wed, 18 Oct 2006 11:35:22 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.63 (FreeBSD)) (envelope-from ) id 1Ga9he-00030a-Tz; Wed, 18 Oct 2006 12:35:18 +0100 Date: Wed, 18 Oct 2006 12:35:18 +0100 From: Ceri Davies To: current@FreeBSD.org Message-ID: <20061018113518.GF92966@submonkey.net> Mail-Followup-To: Ceri Davies , current@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="veXX9dWIonWZEC6h" Content-Disposition: inline X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.13 (2006-08-11) Sender: Ceri Davies Cc: Subject: What to do with quotacheck -l2 ? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2006 11:35:23 -0000 --veXX9dWIonWZEC6h Content-Type: multipart/mixed; boundary="w7PDEPdKQumQfZlR" Content-Disposition: inline --w7PDEPdKQumQfZlR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I found a -l option in quotacheck this morning, which has been there since revision 1.1 and never documented. The option controls the maximum number of concurrent filesystems that quotacheck will operate on during the second pass, and should almost certainly be documented. The -l option is ignored without -a, and using it without -a should result in some kind of warning. However, this behaviour has been unchanged for the entire lifetime of quotacheck in FreeBSD and I'm loathe to break anything, so I turn to you to see if this looks OK. Patch attached, comments welcomed. Thanks, Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --w7PDEPdKQumQfZlR Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="quotacheck-l.diff" Content-Transfer-Encoding: quoted-printable ? quotacheck ? quotacheck.8.gz Index: quotacheck.8 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sbin/quotacheck/quotacheck.8,v retrieving revision 1.16 diff -u -r1.16 quotacheck.8 --- quotacheck.8 10 Feb 2005 09:19:32 -0000 1.16 +++ quotacheck.8 18 Oct 2006 11:25:56 -0000 @@ -31,7 +31,7 @@ .\" @(#)quotacheck.8 8.1 (Berkeley) 6/5/93 .\" $FreeBSD: src/sbin/quotacheck/quotacheck.8,v 1.16 2005/02/10 09:19:32 = ru Exp $ .\" -.Dd June 5, 1993 +.Dd October 18, 2006 .Dt QUOTACHECK 8 .Os .Sh NAME @@ -40,6 +40,7 @@ .Sh SYNOPSIS .Nm .Op Fl guv +.Op Fl l Ar maxrun .Fl a .Nm .Op Fl guv @@ -72,6 +73,13 @@ Only group quotas listed in .Pa /etc/fstab are to be checked. +.It Fl l Ar maxrun +Specifies the maximum number of concurrent file systems +to check in parallel. +If this option is omitted, or if +.Ar maxrun +is zero, parallel passes are run as per +.Xr fsck 8 . .It Fl u Only user quotas listed in .Pa /etc/fstab Index: quotacheck.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sbin/quotacheck/quotacheck.c,v retrieving revision 1.25 diff -u -r1.25 quotacheck.c --- quotacheck.c 10 Feb 2005 09:19:33 -0000 1.25 +++ quotacheck.c 18 Oct 2006 11:25:56 -0000 @@ -192,6 +192,10 @@ (void) addid((u_long)pw->pw_uid, USRQUOTA, pw->pw_name); endpwent(); } + /* Setting maxrun (-l) makes no sense without the aflag, but + it hasn't been an error for over 12 years, so just warn. */ + if (maxrun > 0 && !aflag) + warnx("ignoring -l without -a."); if (aflag) exit(checkfstab(1, maxrun, needchk, chkquota)); if (setfsent() =3D=3D 0) @@ -217,7 +221,7 @@ usage() { (void)fprintf(stderr, "%s\n%s\n",=20 - "usage: quotacheck [-guv] -a", + "usage: quotacheck [-guv] [-l maxrun] -a", " quotacheck [-guv] filesystem ..."); exit(1); } --w7PDEPdKQumQfZlR-- --veXX9dWIonWZEC6h Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFNhF2ocfcwTS3JF8RAih9AKDJEPTZ8AVa7qZSTcp6yj1GTN+l7wCgm1h0 amyqDsCYq/bP9550+nErYJE= =9fR4 -----END PGP SIGNATURE----- --veXX9dWIonWZEC6h--