From owner-freebsd-ports@freebsd.org Tue Nov 6 08:25:11 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46AF7110B3E7 for ; Tue, 6 Nov 2018 08:25:11 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8CDC56C74E for ; Tue, 6 Nov 2018 08:25:10 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (mh0.gentlemail.de [78.138.80.135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id wA68P9uQ087728 for ; Tue, 6 Nov 2018 09:25:09 +0100 (CET) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id 40A70923 for ; Tue, 6 Nov 2018 09:25:09 +0100 (CET) To: freebsd-ports@freebsd.org From: Harry Schmalzbauer Subject: target_COOKIE making a real one? Organization: OmniLAN Message-ID: <3f82673a-5cb4-e6fc-d62c-5c89d0734b6c@omnilan.de> Date: Tue, 6 Nov 2018 09:25:07 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: ACL 130 matched, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [78.138.80.130]); Tue, 06 Nov 2018 09:25:09 +0100 (CET) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: 78.138.80.135; Sender-helo: mh0.gentlemail.de; ) X-Rspamd-Queue-Id: 8CDC56C74E X-Spamd-Result: default: False [0.05 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_LONG(-0.21)[-0.213,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; NEURAL_SPAM_SHORT(0.41)[0.414,0]; MX_GOOD(-0.01)[cached: mx0.gentlemail.de]; DMARC_NA(0.00)[omnilan.de]; NEURAL_HAM_MEDIUM(-0.84)[-0.841,0]; IP_SCORE(-0.00)[country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:25074, ipnet:2a00:e10:2800::/38, country:DE]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 08:25:11 -0000 Sorry, me again, asking hopefully not so stupid questions. Another thing I'm wondering from the beginning is why the target_COOKIE don't store metadata. I think it should be the infrastructure's task to wipe outdated work directories. So if PORTREVISION (stored in BUILD_COOKE) or OPTIONS (stored in CONFIGURE_COOKIE) change, the ${WRKDIR} simply should be removed which leads to a in-sync build.  To my limited view, this seems a quiet simple approch, with quiet high user experience improvement.  This could be extended to record dependencies' COOKIEs hashes in the EXTRACT_COOKIE... I'm writing a wrapper for that (again) for now, but would be curious what others think. Thanks, -harry