From owner-freebsd-arch@FreeBSD.ORG Thu Aug 15 23:17:18 2013 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E5C51B2D; Thu, 15 Aug 2013 23:17:18 +0000 (UTC) (envelope-from arthurmesh@gmail.com) Received: from mail-pb0-x232.google.com (mail-pb0-x232.google.com [IPv6:2607:f8b0:400e:c01::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AB7252F77; Thu, 15 Aug 2013 23:17:18 +0000 (UTC) Received: by mail-pb0-f50.google.com with SMTP id uo5so1344755pbc.37 for ; Thu, 15 Aug 2013 16:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=4BOHwSCHHbXoVGR5WM24td3ahM3lEYD0CclrUskU+WM=; b=lfQJaH7cKP1zZtnISSDDdKETdtTY9Of5hx2SZMNcNPwQ2W19dvPwTUjYpeNt+jYxUI bP48PcBuG0zSSFE4AzUrMhCLOzErN+QsIhqxPBU34A4DBsoBiruKEB+YconSZPLhRShM YA2zeYp0NyIFaONRB3HKnxa310bvF50PKnI1oVVTWFubAPt2yyiAr91ZMUbjWyKJMeXq uhSTaRlmvvIkLfO+plPoXq0IgD8f+UsCCgZmSLtPuwP34pok0/a5WyQUm13nnQ+8G6ue 9U1qDwfb/OVRP0TJ4bSiAIpIoJMXi/2oD/+L3ZVleu3eKxBETxc5y5iXHXCGKNTdhVsq v6Bw== X-Received: by 10.68.211.194 with SMTP id ne2mr18271407pbc.40.1376608638395; Thu, 15 Aug 2013 16:17:18 -0700 (PDT) Received: from x96.org (x96.org. [64.85.165.177]) by mx.google.com with ESMTPSA id xs1sm2034274pac.7.2013.08.15.16.17.16 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 15 Aug 2013 16:17:17 -0700 (PDT) Date: Thu, 15 Aug 2013 16:17:13 -0700 From: Arthur Mesh To: Dag-Erling Sm??rgrav Subject: Re: random(4) plugin infrastructure for mulitple RNG in a modular fashion Message-ID: <20130815231713.GD76666@x96.org> References: <20130807183112.GA79319@dragon.NUXI.org> <86pptfnu33.fsf@nine.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86pptfnu33.fsf@nine.des.no> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-arch@freebsd.org, secteam@freebsd.org, Philip Paeps X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2013 23:17:19 -0000 On Thu, Aug 15, 2013 at 12:09:52PM +0200, Dag-Erling Sm??rgrav wrote: > I still haven't received an answer to my question about options vs > devices. AFAICT there is no reason whatsoever to have padlock or yarrow > as kernel options rather than devices. The fact that they are available > as modules is be a big hint that they should be devices, not options. > The fact that we haven't been consistent in the past is not an excuse to > continue making the same mistake in the present and future. I agree that devices make more sense for yarrow/rdrand/nehemiah. We'll have a patch ready for review by so@ soon. > I also believe that randomness is sufficiently important that we should > have yarrow (or fortuna, when it materializes) in DEFAULTS. Users who > don't want it (or prefer to load it as a module) can disable it with a > nodevice entry in their kernel config. If we go this path, then random itself should also go in to DEFAULTS. Agreed? Does change to DEFAULTS need review by someone other than so@? > BTW, I see that the sysctl was changed (per my request) to return an > empty string if no adaptors are present: > > if (LIST_EMPTY(&adaptors)) > error = SYSCTL_OUT(req, "", strlen("")); > > LIST_FOREACH(rpp, &adaptors, entries) { > if (0 != SYSCTL_OUT(req, rpp->name, strlen(rpp->name))) > break; > } > > but if I read the code correctly, if multiple adaptors are present, > their names will be concatenated with no separator. You probably want > something like this: Yes, it's a bug. David already has a patch (almost) ready for review by so@. Thanks