From owner-cvs-all@FreeBSD.ORG  Thu Jul 14 12:51:53 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DDD7C16A41F;
	Thu, 14 Jul 2005 12:51:53 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (cell.sick.ru [217.72.144.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3BE2F43D45;
	Thu, 14 Jul 2005 12:51:52 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (glebius@localhost [127.0.0.1])
	by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j6ECpkYl018920
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 14 Jul 2005 16:51:46 +0400 (MSD)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.sick.ru (8.13.3/8.13.1/Submit) id j6ECpjDX018919;
	Thu, 14 Jul 2005 16:51:46 +0400 (MSD)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.sick.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Thu, 14 Jul 2005 16:51:45 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Andrew Gallatin <gallatin@cs.duke.edu>
Message-ID: <20050714125145.GA18744@cell.sick.ru>
References: <200507131406.j6DE6DLv066313@repoman.freebsd.org>
	<20050714083608.A21239@grasshopper.cs.duke.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20050714083608.A21239@grasshopper.cs.duke.edu>
User-Agent: Mutt/1.5.6i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/pci if_xl.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jul 2005 12:51:54 -0000

On Thu, Jul 14, 2005 at 08:36:08AM -0400, Andrew Gallatin wrote:
A> Gleb Smirnoff [glebius@FreeBSD.org] wrote:
A> > glebius     2005-07-13 14:06:13 UTC
A> > 
A> >   FreeBSD src repository
A> > 
A> >   Modified files:
A> >     sys/pci              if_xl.c 
A> >   Log:
A> >   NET_LOCK_GIANT() when entering network code.
A> >   
A> 
A> Do other drivers do this?  It looks like at least em, fxp
A> and my out-of-tree commercial driver have the same "bug".

They do. Look at if_ath.c:ath_rx_proc(). This is done in functions
that execute from a separate context - from task queue.
em, fxp and others may not have such functions.

A> I would argue that any fiddling with Giant should go into
A> the various if_input routines instead.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE