From owner-p4-projects@FreeBSD.ORG Fri Aug 4 13:29:59 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 0C88516A4E1; Fri, 4 Aug 2006 13:29:59 +0000 (UTC) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB0A116A4DF for ; Fri, 4 Aug 2006 13:29:58 +0000 (UTC) (envelope-from rdivacky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A5F8943D45 for ; Fri, 4 Aug 2006 13:29:58 +0000 (GMT) (envelope-from rdivacky@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74DTwqL088632 for ; Fri, 4 Aug 2006 13:29:58 GMT (envelope-from rdivacky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74DTwj2088629 for perforce@freebsd.org; Fri, 4 Aug 2006 13:29:58 GMT (envelope-from rdivacky@FreeBSD.org) Date: Fri, 4 Aug 2006 13:29:58 GMT Message-Id: <200608041329.k74DTwj2088629@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to rdivacky@FreeBSD.org using -f From: Roman Divacky To: Perforce Change Reviews Cc: Subject: PERFORCE change 103164 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 13:29:59 -0000 http://perforce.freebsd.org/chv.cgi?CH=103164 Change 103164 by rdivacky@rdivacky_witten on 2006/08/04 13:29:10 The futex_put() must be called symmetrically to futex_get() so do it in the FUTEX_WAKE_OP case. This fixes the memleak with realplay. Affected files ... .. //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_futex.c#15 edit Differences ... ==== //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_futex.c#15 (text+ko) ==== @@ -252,9 +252,9 @@ op_ret = 0; /* Linux always puts there 0 retries */ op_ret += futex_wake(f2, 0, NULL); - futex_put(f2); ret += op_ret; } + futex_put(f2); td->td_retval[0] = ret; break;