Date: Tue, 1 Aug 2006 01:55:00 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Yar Tikhiy <yar@comp.chem.msu.su> Cc: cvs-src@FreeBSD.org, Marcel Moolenaar <marcel@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org, Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: cvs commit: src/usr.sbin/kldxref Makefile Message-ID: <20060731225500.GB46645@frdp.freebsd.org.ua> In-Reply-To: <20060731163209.GB50797@comp.chem.msu.su> References: <200607302051.k6UKpfNU011188@repoman.freebsd.org> <20060731140951.GC48538@comp.chem.msu.su> <EE87FDC1-709D-4B95-9A74-DFF393796664@xcllnt.net> <20060731163209.GB50797@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
--yNb1oOkm5a9FJOVX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Jul 31, 2006 at 08:32:09PM +0400, Yar Tikhiy wrote:
> On Mon, Jul 31, 2006 at 09:10:43AM -0700, Marcel Moolenaar wrote:
> >=20
> > On Jul 31, 2006, at 7:09 AM, Yar Tikhiy wrote:
> >=20
> > >On Sun, Jul 30, 2006 at 08:51:41PM +0000, Marcel Moolenaar wrote:
> > >>marcel 2006-07-30 20:51:41 UTC
> > >>
> > >> FreeBSD src repository
> > >>
> > >> Modified files:
> > >> usr.sbin/kldxref Makefile
> > >> Log:
> > >> Use NO_SHARED=3DYES to force a static link.
> > >>
> > >> Pointed out by: ru@
> > >>
> > >> Revision Changes Path
> > >> 1.9 +1 -1 src/usr.sbin/kldxref/Makefile
> > >
> > >Perhaps it should be spelled just ``NO_SHARED=3D'' in keeping with
> > >the current style?
> >=20
> > I really don't know. Those NO_FOO knobs are not logical in their
> > use.
> >=20
> > > Unfortunately style.Makefile(5) doesn't seem
> > >to list this rule...
> >=20
> > Feel free to change my commit to whatever you think is right.
>=20
> I was sly enough to add Ruslan to Cc in my previous mail :-)
> Let's wait for his opinion on this and below.
>=20
NO_SHARED is special in that it's usually set for a group of
programs, e.g. src/bin/Makefile.inc, and then needs to be
reset for some of them, e.g. src/bin/rmail/Makefile.
> In the meanwhile I peeked in /usr/share/mk and found that the handling
> of NO_* knobs is quite far from being consistent. For example:
>=20
> - NO_MAN -- can be just defined ("YES" and "NO" both mean true),
> handled at <bsd.own.mk> level (note that <bsd.own.mk>
> is often included separately now and includes some magic);
>=20
> - NO_OBJ -- can be just defined to be true, handled in <bsd.obj.mk>,
> which is included from more convenient files like <bsd.prog.mk>;
>=20
> - NO_SHARED -- must be set to something !=3D "no" for the effect,
> handled in <bsd.prog.mk>.
>=20
> I'm unsure if there is a reason behind all this diversity.
>=20
NO_MAN is new style, NO_OBJ is old style and should be easily
convertable, NO_SHARED is old style and not easily convertable.
Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
--yNb1oOkm5a9FJOVX
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (FreeBSD)
iD8DBQFEzopEqRfpzJluFF4RAo5wAJ9ZfNm6zb1IGUEHjfCyUtPz/IFaTwCeNI+5
7puYbvte7dwlqJBrQzgpLRA=
=dtF6
-----END PGP SIGNATURE-----
--yNb1oOkm5a9FJOVX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060731225500.GB46645>