Date: Mon, 23 Dec 2013 11:50:31 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-current@freebsd.org Cc: dt71@gmx.com, Adrian Chadd <adrian@freebsd.org>, Robert Noland <rnoland@freebsd.org>, =?iso-8859-1?q?Jean-S=E9bastien?= =?iso-8859-1?q?_P=E9dron?= <dumbbell@freebsd.org> Subject: Re: new Xorg (KMS, etc.) for Radeon 9600 Message-ID: <201312231150.31936.jhb@freebsd.org> In-Reply-To: <CAJ-Vmo=_vHi_NG_3aOW00_aGwDV==wP-h6BNBx6DA0k-cA8zvw@mail.gmail.com> References: <527F95BE.7080908@gmx.com> <52B17777.6060703@FreeBSD.org> <CAJ-Vmo=_vHi_NG_3aOW00_aGwDV==wP-h6BNBx6DA0k-cA8zvw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, December 18, 2013 2:43:28 pm Adrian Chadd wrote: > [snip] > > So the standard trop of UNLOCK/WORK/RELOCK is pretty dangerous. > There's no state re-validation going on when you re-acquire that lock. > So, although it meets the lock requirements, it may not be 'correct'. > > It's scattered throughout the code base (wifi drivers aren't an > exception here either, sigh.) > > Just something to keep in mind when you validate the 'correctness' of > this kind of lock hack. Agreed. It needs fixing, but the fix needs to be correct. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312231150.31936.jhb>