Date: Sat, 09 Sep 2017 13:22:16 -0700 From: Cy Schubert <Cy.Schubert@komquats.com> To: Warner Losh <imp@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323375 - head/sys/modules/uart Message-ID: <201709092022.v89KMGmg020867@slippy.cwsent.com> In-Reply-To: Message from Warner Losh <imp@FreeBSD.org> of "Sat, 09 Sep 2017 20:14:18 -0000." <201709092014.v89KEITK099701@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <201709092014.v89KEITK099701@repo.freebsd.org>, Warner Losh writes: > Author: imp > Date: Sat Sep 9 20:14:18 2017 > New Revision: 323375 > URL: https://svnweb.freebsd.org/changeset/base/323375 > > Log: > Don't build uart_dev_mvebu unless we're on arm64. > > This module is specific to a single Marvel board that we currently > only support in 64-bit mode. Remove it from the build otherwise. It > likely should be completely removed, but this unbreaks x86 building. > > Noticed by: sbruno@ > > Modified: > head/sys/modules/uart/Makefile > > Modified: head/sys/modules/uart/Makefile > ============================================================================= > = > --- head/sys/modules/uart/Makefile Sat Sep 9 20:08:26 2017 (r32337 > 4) > +++ head/sys/modules/uart/Makefile Sat Sep 9 20:14:18 2017 (r32337 > 5) > @@ -25,12 +25,16 @@ _uart_cpu=uart_cpu_${MACHINE}.c > uart_cpu_machine= ${_uart_cpu} > .endif > > +.if ${MACHINE} == "arm64" > +uart_dev_mvebu=uart_dev_mvebu.c > +.endif > + > KMOD= uart > SRCS= uart_bus_acpi.c ${uart_bus_ebus} uart_bus_isa.c uart_bus_pccard > .c \ > uart_bus_pci.c uart_bus_puc.c uart_bus_scc.c \ > uart_core.c ${uart_cpu_machine} uart_dbg.c \ > ${uart_dev_lpc} uart_dev_ns8250.c uart_dev_quicc.c uart_dev_sab82532.c > \ > - uart_dev_z8530.c uart_dev_mvebu.c \ > + uart_dev_z8530.c ${uart_dev_mvebu} \ > uart_if.c uart_if.h uart_subr.c uart_tty.c > > SRCS+= acpi_if.h bus_if.h card_if.h device_if.h isa_if.h ${ofw_bus_if} > \ > Thank you. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201709092022.v89KMGmg020867>