From owner-freebsd-toolchain@FreeBSD.ORG Thu Mar 26 18:47:19 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E5DD64E3 for ; Thu, 26 Mar 2015 18:47:19 +0000 (UTC) Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id ABB877F9 for ; Thu, 26 Mar 2015 18:47:19 +0000 (UTC) Received: by pacwe9 with SMTP id we9so71004146pac.1 for ; Thu, 26 Mar 2015 11:47:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=0ElUQpL8X92qD8gzZFUaPzJ/155Xxu/s0Dv7DbIVXqI=; b=VjPmeLf9yqVDiFzsDYYq6Rfq7un9jo+Q1Y5PRUZyuQTLSZ9nUx9uBg9a5L9Q5xa6q+ oUthH65ISzl3VUouTgkmRy96p1lodLtPlkXmLw6t8aiE6ERP9L0pXRYfYwDfJgInUY64 TwsUuRF+H7+3zf3H+uN02NUSA+mNPPit01DLvfq+1+fbWSBWKSbKlO0WUEox94JNB+YD odeyqkFptfMBCfqPkAfq0Ct+8qVSdWblRDci87gZNSNXVD3QhxkBdqWIqAu9qtxgHA7O WNHTaYOA9wGRVVDu1eVh2cga92MbqP0ZJp3Oz+T8YQz5CBlYi9gldqUhP7KZlQu4eygJ bKlw== X-Gm-Message-State: ALoCoQlkgTE4DnTMSzLmyxyt68YNFccCgmf9gcBboPyPOSb3u102BtFBPNSTkvEuif2NXkmQDM7N X-Received: by 10.68.113.161 with SMTP id iz1mr28976698pbb.30.1427395633669; Thu, 26 Mar 2015 11:47:13 -0700 (PDT) Received: from [10.64.25.105] ([69.53.236.236]) by mx.google.com with ESMTPSA id pr1sm6290423pbc.66.2015.03.26.11.47.12 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 26 Mar 2015 11:47:12 -0700 (PDT) Sender: Warner Losh Subject: Re: Failed to build with external toolchain Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_53C848BF-B03D-4A9E-BD33-490E9A632FF2"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Warner Losh In-Reply-To: Date: Thu, 26 Mar 2015 12:47:26 -0600 Message-Id: <1A90C16A-1A23-4EFD-BB61-0E956C8CB49D@bsdimp.com> References: <1857A2A3-0C19-4F52-BCAF-6C72FE7D8DF3@FreeBSD.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2015 18:47:20 -0000 --Apple-Mail=_53C848BF-B03D-4A9E-BD33-490E9A632FF2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 > On Mar 26, 2015, at 2:12 AM, Craig Rodrigues = wrote: >=20 >=20 >=20 > On Tue, Mar 24, 2015 at 8:39 PM, Warner Losh wrote: >=20 >=20 > No. The in-tree gcc doesn=92t grok =97sysroot. >=20 > We assume that version gcc 4.2.1 is special and our in-tree compiler = elsewhere, > so please add a check for that and just go ahead and duplicate those = two lines. >=20 > Eg >=20 > +.else if ${COMPILER_VERSION} > 40201 > +XCFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > +XCXXFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > .endif >=20 >=20 > The following worked for me. Is it OK to commit? >=20 > Index: Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- Makefile.inc1 (revision 280353) > +++ Makefile.inc1 (working copy) > @@ -375,10 +375,14 @@ > .endif > .if defined(X_COMPILER_TYPE) && ${X_COMPILER_TYPE} =3D=3D gcc > XCFLAGS+=3D -isystem ${WORLDTMP}/usr/include = -L${WORLDTMP}/usr/lib > XCXXFLAGS+=3D -I${WORLDTMP}/usr/include/c++/v1 -std=3Dgnu++11 = -L${WORLDTMP}/../lib/libc++ > DEPFLAGS+=3D -I${WORLDTMP}/usr/include/c++/v1 > +.if ${COMPILER_VERSION} > 40201 > +XCFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > +XCXXFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > +.endif > .else > TARGET_ABI?=3D unknown > TARGET_TRIPLE?=3D = ${TARGET_ARCH:C/amd64/x86_64/}-${TARGET_ABI}-freebsd11.0 > XCFLAGS+=3D -target ${TARGET_TRIPLE} > XCFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} OK. I have a bit of egg on my face=85 The test is for X_COMPILER_TYPE, so COMPILER_VERSION isn=92t relevant. = It=92s always outside the tree. So your original patch is correct. Please go ahead and commit that and = accept my apologies for the wild goose chase. Warner --Apple-Mail=_53C848BF-B03D-4A9E-BD33-490E9A632FF2 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVFFQ+AAoJEGwc0Sh9sBEAyi0QAKD7MsHe58oHThFw0Du2jmRi 9Y2qpVuaWa3RmHVRb1cZewowtxWOIGnaFE8MWWSd8S0PE3gaO8nOzzUQV9FndMHp FETLvRX7bL0I+sJ/nZwQt4Sb4oOH4hv5KgoeXz/aShO5MKdAFOp7CjG6iLlkpGwg qts/d313jeeqkPBiwtAMhtXzVIW8LALHF0YyEE6bGlyO9k9f9ZLCVgZmFF+sNN1x S+I9qGNI3Oum3eTJ36uHMQmteJbKjIf1HgqMlhlms0UAJRUcKBlKQuqMExRGCtu/ 1AWL66smfYe2ofFutsFlmTVSXs/yNdDz0dwpbcYx2OgUMEH2h6ngNtRIgXyRj6fK eIouQp5/WKrMg6dgVibkPX923MOfG2xAJ3YmhlM13kq+s6ilocJ4GrZ75zDitdAg bDabyuMMRU2CF2qWQgDKPo69ICEcORrnG6rC5gjJNjR+c0F6LUejfYnxYs8Sui81 AMhGRBWv8I6V6vPC0jX1BamsM7dtTD+u0OKVFlc8GaiZJteRrk+U/WhFD7rHNxcC +L4t6zjh/2q/fXkxTfIPXWqzsAAPBa2KI/EOPvwxebIy/bjbz3g08fzZzAB/sDdy Olty3pnjETZbnsKxI9VVgJzc+DIumRjlnJyIgVWUhIEaFfEabQRmKobIdAzdp/ON /9rdAMWvh8v/9Qz92EIX =t/wk -----END PGP SIGNATURE----- --Apple-Mail=_53C848BF-B03D-4A9E-BD33-490E9A632FF2--