From owner-freebsd-hackers@FreeBSD.ORG Fri May 11 09:54:20 2012 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49AE5106566C; Fri, 11 May 2012 09:54:20 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 2EEE28FC12; Fri, 11 May 2012 09:54:18 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA15403; Fri, 11 May 2012 12:54:17 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1SSmYD-0004H2-B8; Fri, 11 May 2012 12:54:17 +0300 Message-ID: <4FACE1C8.4080802@FreeBSD.org> Date: Fri, 11 May 2012 12:54:16 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:12.0) Gecko/20120503 Thunderbird/12.0.1 MIME-Version: 1.0 To: John Baldwin References: <4F8999D2.1080902@FreeBSD.org> <201205070953.04032.jhb@freebsd.org> <4FA7E069.8020208@FreeBSD.org> <201205071343.45955.jhb@freebsd.org> <4FA8C7E3.8070006@FreeBSD.org> <4FA92A88.2030000@FreeBSD.org> <4FA96747.3060106@FreeBSD.org> <4FAA3994.2070701@FreeBSD.org> <4FAA54C1.20203@FreeBSD.org> <4FAB8D31.8050301@FreeBSD.org> <4FABDC23.2090400@FreeBSD.org> In-Reply-To: <4FABDC23.2090400@FreeBSD.org> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-hackers@FreeBSD.org, Takahashi Yoshihiro Subject: Re: bootargs.h X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2012 09:54:20 -0000 on 10/05/2012 18:17 John Baldwin said the following: > On 5/10/12 5:41 AM, Andriy Gapon wrote: >> on 09/05/2012 14:28 John Baldwin said the following: >>> On 5/9/12 5:32 AM, Andriy Gapon wrote: >>>> >>>> Here is a subversion diff to make use of the new bootargs.h header in pc98 >>>> cdboot and loader, and i386 cdboot and pxeldr: >>>> http://people.freebsd.org/~avg/bootargs.diff >>>> Could you please review it? >>>> Thank you! >>> >>> Looks good. >>> >>>> MFi386 of BTX changes for support of KARGS_FLAGS_EXTARG is pending. >>>> Do you think that it should be done? >>> >>> You mean to pc98's btxldr? I think so, in general we should keep the >>> pc98 BTX bits as close to i386 as possible. >>> >> >> Yes. Here is a complete pc98 patch for bootargs.h and btxldr: >> http://people.freebsd.org/~avg/pc98-btxldr.diff > > Looks ok to me. We should really see about letting PC98 share more code > here rather than using copies if it's not too ugly. > btxcsu.S is the only one that is almost identical between i386 and pc98. I think that it was completely identical and I accidentally broke that. Should fix. btxldr.S and btx.S would require a fair number of ifdefs to be shareable. cdboot.S seems to have too many differences. I am not sure whether and what it would make sense to share. -- Andriy Gapon