From owner-svn-ports-head@FreeBSD.ORG Sun Nov 16 17:47:49 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4B37E871; Sun, 16 Nov 2014 17:47:49 +0000 (UTC) Received: from elvis.mu.org (elvis.mu.org [IPv6:2001:470:1f05:b76::196]) by mx1.freebsd.org (Postfix) with ESMTP id 2BB941E4; Sun, 16 Nov 2014 17:47:49 +0000 (UTC) Received: from [10.0.1.100] (c-76-21-10-192.hsd1.ca.comcast.net [76.21.10.192]) by elvis.mu.org (Postfix) with ESMTPSA id BDE27341F83D; Sun, 16 Nov 2014 09:47:48 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r372622 - in head/editors/vim: . files From: Alfred Perlstein X-Mailer: iPhone Mail (12B411) In-Reply-To: <20141116113525.GH45145@ivaldir.etoilebsd.net> Date: Sun, 16 Nov 2014 09:47:49 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201411160232.sAG2WJ4Z084790@svn.freebsd.org> <54687C89.20206@gmx.de> <20141116113345.GG45145@ivaldir.etoilebsd.net> <20141116113525.GH45145@ivaldir.etoilebsd.net> To: Baptiste Daroussin Cc: "svn-ports-head@freebsd.org" , Olli Hauer , "svn-ports-all@freebsd.org" , Alfred Perlstein , "ports-committers@freebsd.org" , Mathieu Arnold X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Nov 2014 17:47:49 -0000 I can install those instead. Should I change it? Sent from my iPhone > On Nov 16, 2014, at 3:35 AM, Baptiste Daroussin wrote: >=20 >> On Sun, Nov 16, 2014 at 12:33:45PM +0100, Baptiste Daroussin wrote: >>> On Sun, Nov 16, 2014 at 12:24:04PM +0100, Mathieu Arnold wrote: >>> +--On 16 novembre 2014 11:29:29 +0100 olli hauer wrote: >>> |> +.if ${PORT_OPTIONS:MDEFAULT_VIMRC} >>> |> + ${INSTALL_DATA} ${FILESDIR}/vimrc >>> |> ${STAGEDIR}${DEFAULT_VIMRC_LOCATION}/vimrc +.endif >>> |> =20 >>> | ... >>> |=20 >>> | Thanks for installing a default vimrc file, but isn't it safer to inst= all >>> | the vimrc file with the @sample macro to protect users having already a= >>> | own vimrc file installed? >>>=20 >>> Yes, please, install a .sample file and use @sample in the plist, you're= >>> going to overwrite people's existing vimrc. >> I first asked alfred to do such before the commit. >>=20 >> But when looking at how vim handles vimrc this is a fallback location hen= ce this >> vimrc is only loaded only if there is no user supplied vimrc >>=20 >> ':version' will show you: >> system vimrc file: "$VIM/vimrc" >> user vimrc file: "$HOME/.vimrc" >> 2nd user vimrc file: "~/.vim/vimrc" >> user exrc file: "$HOME/.exrc" >> fall-back for $VIM: "/usr/local/share/vim" >>=20 >> So now I'm thinking there is no need for a @sample ...vimrc.sample given t= his >> vimrc is doing to be installed in the fall-back location. >>=20 >> But I do not think adding yet another option is worth, it should probably= always >> be installed. >>=20 >> Regards, >> Bapt >=20 > That said isn't using the default upstream provided vimrc a better option t= han a > custom one? > /usr/local/share/vim/vim74/vimrc_example.vim as vimrc > and probably /usr/local/share/vim/vim74/gvimrc_example.vim as gvimrc? >=20 > Best regards, > Bapt