From owner-svn-ports-all@freebsd.org Wed Jul 18 13:54:41 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E661104B0F4; Wed, 18 Jul 2018 13:54:41 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 230BB7B310; Wed, 18 Jul 2018 13:54:41 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from ogg.in.absolight.net (ogg.in.absolight.net [IPv6:2a01:678:ab:50::42:42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 7127E1D4D5; Wed, 18 Jul 2018 13:54:40 +0000 (UTC) (envelope-from mat@FreeBSD.org) Date: Wed, 18 Jul 2018 15:54:32 +0200 From: Mathieu Arnold To: Babak Farrokhi Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r474859 - in head/sysutils: . omnibackup omnibackup/files Message-ID: <20180718135432.zkwre46ms6fnefeo@ogg.in.absolight.net> References: <201807181248.w6ICmXKg064609@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lkntcoddxnhptn4q" Content-Disposition: inline In-Reply-To: <201807181248.w6ICmXKg064609@repo.freebsd.org> User-Agent: NeoMutt/20180622 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2018 13:54:41 -0000 --lkntcoddxnhptn4q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable First off, everything is badly placed, for example, but not limited to, OPTIONS where the DEPENDS should be. On Wed, Jul 18, 2018 at 12:48:33PM +0000, Babak Farrokhi wrote: > +RUN_DEPENDS+=3D \ Why +=3D ? > +SUB_FILES=3D pkg-message > +SUB_LIST=3D ROOT_HOME=3D/root SUB_LIST is for variables, ROOT_HOME is pretty static, no need to use a placeholder for it. > +PLIST_FILES=3D \ > + bin/omnibackup \ > + ${ETCDIR}/config.json.sample This should be using @sample. > +.include > + > +.if ${PORT_OPTIONS:MDOCS} > +PLIST_FILES+=3D ${DOCSDIR}/README.md > +.endif All this could be replaced by: PORTDOCS=3Dreadme.md > +.if ${PORT_OPTIONS:MOPENLDAP} \ > + || ${PORT_OPTIONS:MPGSQL} \ > + || ${PORT_OPTIONS:MMYSQL} > +RUN_DEPENDS+=3D sudo:security/sudo > +.if ${PORT_OPTIONS:MOPENLDAP} > +RUN_DEPENDS+=3D slapcat:net/openldap24-server > +.endif > +.if ${PORT_OPTIONS:MPGSQL} > +USES+=3D pgsql > +RUN_DEPENDS+=3D pg_dump:databases/postgresql${PGSQL_VER_NODOT}-client > +RUN_DEPENDS+=3D pg_dumpall:databases/postgresql${PGSQL_VER_NODOT}-client Those three lines all do the same thing, except that the last two are awful. > +.endif > +.if ${PORT_OPTIONS:MMYSQL} > +USES+=3D mysql > +RUN_DEPENDS+=3D mysqldump:${_MYSQL_CLIENT} Same here, only the first is required. > Added: head/sysutils/omnibackup/files/pkg-message.in > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/sysutils/omnibackup/files/pkg-message.in Wed Jul 18 12:48:33 201= 8 (r474859) > @@ -0,0 +1,32 @@ > +########################################################################= ####### > + > +In order to run OmniBackup, you will need to create and configure the ma= in > +configuration file, e.g.: > + > +$ cp -p %%LOCALBASE%%/etc/omnibackup/config.json.sample \ > + %%LOCALBASE%%/etc/omnibackup/config.json This should be PREFIX, not LOCALBASE. > +or, create it in the root users' home directory: > + > +$ cp -p %%LOCALBASE%%/etc/omnibackup/config.json.sample \ > + %%ROOT_HOME%%/.omnibackup/config.json This should be PREFIX. > +In order to take automatic backups every 24 hours at 01:00am UTC run this > +command: > + > +$ crontab -e -u root > + > +Then add the following lines to the root users' crontab: > + > +# OmniBackup daily backups > +00 01 * * * %%LOCALBASE%%/bin/omnibackup PREFIX. > +To avoid data loss, make sure to consult the documentation at: > + > +* %%LOCALBASE%%/share/doc/omnibackup/README.md PREFIX --=20 Mathieu Arnold --lkntcoddxnhptn4q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAltPRpdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkjg0A/+Ml3tzhEsjCf/B9GEW5ze9Xu7yn4Ii0VYUbjkqUsRlb1nJ+UxPhr2eh9m GdaZ8X2UoLWIFwbCAC7RsQV+odGKXTOX49oRe+bYgHRX74ckZUW6s39un7vvm7cO +wJR3IuLBKGQXdUqIE+KG6WbnFSlOzSOKQwySFj143tQ21bwk0XeoqKoNzSP9alb 9rjmyXc9zCb28qvywbefvTA/SY8QWBc0Mwy4lfBO2afcKcODfZaT413Mv0gviE0A q4slpOVmzCukdJBBIoK152vJuC1Nyip47y7if6qraAD+u0PxSXMbPKI6gVcn8req OStorB2DAUV5HyCiXaLqG3wGarWwYrH9alK7gTc3m/nzcxl2vTgoV2aDbl/VAru4 vjDhqT7aF7cdEq7YjGKAf/tDRIhGhdNRKOkg2iE0nvCTQTQlrYOV65Abf+w60j2s E69xrzoDZR8ZdGRl3Qdio1WLP2gvH5weg31cAzYsv/8XMUdnr+9Xe26hgqJkiUfI N+vYGhc/dno/0ZlN7903ducSYiA7fNDQsK30vIbk3zpJSD392gRAi8E4w1eQJqDo ohngELjmOVAgWyUsPESEcQyEn19vCKy84Bb4C5t11oNNPz2wzo7NfZDqVuGSKlj0 mfkczXhTqwBGr16etbobwHeJa/lNs+ZKhMKkn6U64h6gXyOvYhk= =wErA -----END PGP SIGNATURE----- --lkntcoddxnhptn4q--