From owner-svn-src-head@FreeBSD.ORG  Thu May 15 13:52:03 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5AE01917;
 Thu, 15 May 2014 13:52:03 +0000 (UTC)
Received: from i3mail.icecube.wisc.edu (i3mail.icecube.wisc.edu
 [128.104.255.23])
 by mx1.freebsd.org (Postfix) with ESMTP id 2DF372A70;
 Thu, 15 May 2014 13:52:02 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by i3mail.icecube.wisc.edu (Postfix) with ESMTP id A202638054;
 Thu, 15 May 2014 08:52:02 -0500 (CDT)
X-Virus-Scanned: amavisd-new at icecube.wisc.edu
Received: from i3mail.icecube.wisc.edu ([127.0.0.1])
 by localhost (i3mail.icecube.wisc.edu [127.0.0.1]) (amavisd-new, port 10030)
 with ESMTP id HNimfOY6t9pe; Thu, 15 May 2014 08:52:02 -0500 (CDT)
Received: from comporellon.tachypleus.net (polaris.tachypleus.net
 [75.101.50.44])
 by i3mail.icecube.wisc.edu (Postfix) with ESMTPSA id 1BC9A38056;
 Thu, 15 May 2014 08:52:02 -0500 (CDT)
Message-ID: <5374C681.9080505@freebsd.org>
Date: Thu, 15 May 2014 06:52:01 -0700
From: Nathan Whitehorn <nwhitehorn@freebsd.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Justin Hibbits <jhibbits@freebsd.org>, src-committers@freebsd.org, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r266116 - head/sys/powerpc/aim
References: <201405150418.s4F4I7q4048799@svn.freebsd.org>
 <5374C4EE.9040201@freebsd.org>
In-Reply-To: <5374C4EE.9040201@freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 May 2014 13:52:03 -0000

On 05/15/14 06:45, Nathan Whitehorn wrote:
> On 05/14/14 21:18, Justin Hibbits wrote:
>> Author: jhibbits
>> Date: Thu May 15 04:18:06 2014
>> New Revision: 266116
>> URL: http://svnweb.freebsd.org/changeset/base/266116
>>
>> Log:
>>    A page mask size is 12-bits, not 11.
>>       MFC after:    1 week
>>
>> Modified:
>>    head/sys/powerpc/aim/trap_subr32.S
>>
>> Modified: head/sys/powerpc/aim/trap_subr32.S
>> ============================================================================== 
>>
>> --- head/sys/powerpc/aim/trap_subr32.S    Thu May 15 03:47:52 2014    
>> (r266115)
>> +++ head/sys/powerpc/aim/trap_subr32.S    Thu May 15 04:18:06 2014    
>> (r266116)
>> @@ -677,7 +677,7 @@ disitrap:
>>       mtcr    %r31
>>       bt    17,realtrap        /* branch is user mode */
>>       mfsprg1    %r31            /* get old SP */
>> -    clrrwi    %r31,%r31,11        /* Round SP down to nearest page */
>> +    clrrwi    %r31,%r31,12        /* Round SP down to nearest page */
>>       sub.    %r30,%r31,%r30        /* SP - DAR */
>>       bge    1f
>>       neg    %r30,%r30        /* modulo value */
>>
>
> Is it? 4096 bytes is 2^12. The mask is 4096-1, which is 11 bits all 1.
> -Nathan
>

Sorry, I can't do math. Please ignore this email.
-Nathan