Date: Sat, 22 Feb 2014 14:51:50 -0500 (EST) From: Chris Nehren <cnehren@pobox.com> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/186962: minbif only needs imlib2 if the user wants caca Message-ID: <20140222195150.0F6B86D46B@b-sasl-quonix.pobox.com> Resent-Message-ID: <201402222000.s1MK006Y034091@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 186962
>Category: ports
>Synopsis: minbif only needs imlib2 if the user wants caca
>Confidential: no
>Severity: serious
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Feb 22 20:00:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: apeiron
>Release: FreeBSD 9.2-RELEASE-p3 amd64
>Organization:
>Environment:
System: FreeBSD eschaton.local 9.2-RELEASE-p3 FreeBSD 9.2-RELEASE-p3 #0: Sat Jan 11 03:25:02 UTC 2014 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
irc/minbif latest as of date of PR submission
>Description:
irc/minbif requires imlib2, regardless of whether it's actually
needed for the port to function. In reality, imlib2 is only
needed when the user selects caca support. I've attached a patch
that fixes the dependencies and disables libcaca and imlib2
support if the user doesn't select caca.
>How-To-Repeat:
Try to build minbif without imlib2 installed.
Observe minbif installation recurse into imlib2 port, despite not
needing it.
>Fix:
See below.
--- Makefile.orig 2014-02-22 14:36:04.000000000 -0500
+++ Makefile 2014-02-22 14:43:45.000000000 -0500
@@ -25,8 +25,6 @@
USES= cmake pkgconfig
USE_GNOME= glib20
-USE_EFL= imlib2
-CMAKE_ARGS= -DENABLE_IMLIB:BOOL=ON
CFLAGS+= -DX_DISPLAY_MISSING
LDFLAGS+= -pthread
@@ -66,6 +64,14 @@
CMAKE_ARGS+= -DENABLE_VIDEO:BOOL=OFF
.endif
+.if ${PORT_OPTIONS:MCACA}
+USE_EFL= imlib2
+CMAKE_ARGS+= -DENABLE_IMLIB:BOOL=ON
+.else
+CMAKE_ARGS+= -DENABLE_CACA:BOOL=OFF
+CMAKE_ARGS+= -DENABLE_IMLIB:BOOL=OFF
+.endif
+
.if ${PORT_OPTIONS:MVIDEO} && empty(PORT_OPTIONS:MCACA)
IGNORE= if you want to enable webcam support, you must \
also enable CACA.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140222195150.0F6B86D46B>