From owner-svn-src-head@freebsd.org  Sat Dec 12 15:31:11 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 954D8A1429A;
 Sat, 12 Dec 2015 15:31:11 +0000 (UTC) (envelope-from devin@shxd.cx)
Received: from shxd.cx (mail.shxd.cx [64.201.244.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 85AEB1E14;
 Sat, 12 Dec 2015 15:31:11 +0000 (UTC) (envelope-from devin@shxd.cx)
Received: from [64.201.244.132] (port=64765 helo=[10.0.0.108])
 by shxd.cx with esmtps (TLSv1:AES256-SHA:256) (Exim 4.77 (FreeBSD))
 (envelope-from <devin@shxd.cx>)
 id 1a7gP7-0000Jt-4x; Sat, 12 Dec 2015 01:23:49 -0800
From: Devin Teske <devin@shxd.cx>
Mime-Version: 1.0 (1.0)
Subject: Re: svn commit: r291913 - head/tools/tools/nanobsd
Date: Sat, 12 Dec 2015 07:27:09 -0800
Message-Id: <4D007463-F8E5-4092-9FA4-0396E0A1444D@shxd.cx>
References: <201512070402.tB742V3Z081964@repo.freebsd.org>
 <CA+q+TcrSPfGgwy5majfhHZUdKiE4iO8rmkkJY3dzGWTUFut5yQ@mail.gmail.com>
Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>,
 svn-src-head <svn-src-head@freebsd.org>, Devin Teske <dteske@freebsd.org>
In-Reply-To: <CA+q+TcrSPfGgwy5majfhHZUdKiE4iO8rmkkJY3dzGWTUFut5yQ@mail.gmail.com>
To: =?utf-8?Q?Olivier_Cochard-Labb=C3=A9?= <olivier@cochard.me>
X-Mailer: iPhone Mail (13B143)
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.20
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Dec 2015 15:31:11 -0000



> On Dec 11, 2015, at 11:55 PM, Olivier Cochard-Labb=C3=A9 <olivier@cochard.=
me> wrote:
>=20
>> On Mon, Dec 7, 2015 at 5:02 AM, Warner Losh <imp@freebsd.org> wrote:
>=20
>> Author: imp
>> Date: Mon Dec  7 04:02:31 2015
>> New Revision: 291913
>> URL: https://svnweb.freebsd.org/changeset/base/291913
>>=20
>> Log:
>>   Generally use shorter, more idiomatic sh expressions in a bunch of
>>   places.
>>=20
>> Modified:
>>   head/tools/tools/nanobsd/defaults.sh   (contents, props changed)
>=20
>=20
> =E2=80=8BHi,
>=20
> I beleive there is a tipo here :
> =E2=80=8B=20
>>=20
>> Modified: head/tools/tools/nanobsd/defaults.sh
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
>> --- head/tools/tools/nanobsd/defaults.sh        Mon Dec  7 04:02:19 2015 =
       (r291912)
>> +++ head/tools/tools/nanobsd/defaults.sh        Mon Dec  7 04:02:31 2015 =
       (r291913)
>>=20
>>  #######################################################################
>> @@ -949,21 +949,21 @@ export_var ( ) {          # Don't wawnt a subshe
>>  # Call this function to set defaults _after_ parsing options.
>>  # dont want a subshell otherwise variable setting is thrown away.
>>  set_defaults_and_export ( ) {
>> -       test -n "${NANO_OBJ}" || NANO_OBJ=3D/usr/obj/nanobsd.${NANO_NAME}=

>> -       test -n "${MAKEOBJDIRPREFIX}" || MAKEOBJDIRPREFIX=3D${NANO_OBJ}
>> -       test -n "${NANO_DISKIMGDIR}" || NANO_DISKIMGDIR=3D${NANO_OBJ}
>> +       : ${NANO_OBJ:=3D/usr/obj/nanobsd.${NANO_NAME}}
>> +       : ${MAKEOBJDIRPREFIX:=3D${NANO_OBJ}}
>> +       : ${NANO_DISKIMGDIR=3D:${NANO_OBJ}}
>>         NANO_WORLDDIR=3D${NANO_OBJ}/_.w
>>         NANO_MAKE_CONF_BUILD=3D${MAKEOBJDIRPREFIX}/make.conf.build
>>         NANO_MAKE_CONF_INSTALL=3D${NANO_OBJ}/make.conf.install
>=20
> =E2=80=8BNotice the line:
> : ${NANO_DISKIMGDIR=3D:${NANO_OBJ}}

Author meant ":=3D" instead of "=3D:"
--=20
Devin=