Date: Sun, 2 Jan 2022 17:22:39 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: daf481f3d508 - main - rescue: include ping iff at least one of INET & INET6 is enabled Message-ID: <50E91562-8850-43CD-AF44-34A96085EF41@freebsd.org> In-Reply-To: <YdHeJSMMJP3t750f@FreeBSD.org> References: <202112311818.1BVIIr2P048142@gitrepo.freebsd.org> <YdHeJSMMJP3t750f@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2 Jan 2022, at 17:17, Gleb Smirnoff <glebius@freebsd.org> wrote: >=20 > On Fri, Dec 31, 2021 at 06:18:53PM +0000, Ed Maste wrote: > E> The branch main has been updated by emaste: > E>=20 > E> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Ddaf481f3d508e7497b456e8df7db17c9= 0b623ee0 > E>=20 > E> commit daf481f3d508e7497b456e8df7db17c90b623ee0 > E> Author: Ed Maste <emaste@FreeBSD.org> > E> AuthorDate: 2021-12-31 01:11:31 +0000 > E> Commit: Ed Maste <emaste@FreeBSD.org> > E> CommitDate: 2021-12-31 18:16:30 +0000 > E>=20 > E> rescue: include ping iff at least one of INET & INET6 is = enabled > E> =20 > E> Ping does not build (and serves no purpose) if neither is = enabled > E> (i.e., building WITHOUT_INET and WITHOUT_INET6). > E> =20 > E> This is equvalent to a4ef9e58bc0c but for rescue/. > E> =20 > E> PR: 260082 > E> Fixes: a4ef9e58bc0c ("sbin: build ping if at least one = of...") > E> Sponsored by: The FreeBSD Foundation >=20 > Shouldn't be ping built only with INET and ping6 with INET6? > Is there any use of ping on machine that doesn't have IPv4? ping does both these days: commit 0b1064b00fa3ed9c6ac31e2af1fc56c528d7b47d Author: asomers <asomers@FreeBSD.org> Date: Thu Nov 26 04:29:30 2020 +0000 Merge ping6 to ping =20 There is now a single ping binary, which chooses to use ICMP or = ICMPv4 based on the -4 and -6 options, and the format of the address. =20 Submitted by: J=C3=A1n Su=C4=8Dan <sucanjan@gmail.com> Sponsored by: Google LLC (Google Summer of Code 2019) MFC after: Never Differential Revision: https://reviews.freebsd.org/D21377 Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50E91562-8850-43CD-AF44-34A96085EF41>