From nobody Wed Jun 18 07:56:45 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bMbgH6G7Hz5yPXl; Wed, 18 Jun 2025 07:57:15 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from mail.bsd4all.net (mail.bsd4all.net [IPv6:2a01:4f8:13b:240c::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bMbgH0dQJz3VY5; Wed, 18 Jun 2025 07:57:15 +0000 (UTC) (envelope-from herbert@gojira.at) Authentication-Results: mx1.freebsd.org; none Date: Wed, 18 Jun 2025 09:56:45 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gojira.at; s=mail202005; t=1750233427; bh=Lhq3SW2PHZn1mQZch2ks+9mC21oQfc5KT8yIz8nYQUQ=; h=Date:Message-ID:From:To:Cc:Subject:MIME-Version:Content-Type; b=GYr73BDhF8Pio9lZ5/pCdhVGt3jdZHMbitTsKlNsCJDHCgoU9f+ETUG7oTBiSaJCN IDyBnpYv2567Y8SAxiqWFQ2YNmsf7e/g+0YUKBkxGcrRTPZNID8Jvr2I7u8v1nKQR6 EXgSvMjxSI0tVXWdu6RkKFXz49+JUQHRBHah31nU5eKye9CH5a7dDvEepXVsQctfvU +3JnWXj+0eISufc+GC4/f2eubtANFrbZwTYcEh2f3/rgkOjUo3OjIhfW3bqBWEBGC1 TVrn/CzUfdCn7hBa2T+hT00ARWb/2YDlaCljeZilay3rxKTSiE7qiscRhU60nLyEiY UsSa2Kx4M0RIw== Message-ID: <87zfe5qy82.wl-herbert@gojira.at> From: "Herbert J. Skuhra" To: Olivier Certner Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2fefe2c88b31 - main - runq: Deduce most parameters, remove machine headers In-Reply-To: <202506180213.55I2D7hj023933@gitrepo.freebsd.org> References: <202506180213.55I2D7hj023933@gitrepo.freebsd.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/31.0 Mule/6.0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4bMbgH0dQJz3VY5 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE] On Wed, 18 Jun 2025 04:13:07 +0200, Olivier Certner > The branch main has been updated by olce: > > URL: https://cgit.FreeBSD.org/src/commit/?id=2fefe2c88b31dc7f173c9424f3eb13d49e98d55a > > commit 2fefe2c88b31dc7f173c9424f3eb13d49e98d55a > Author: Olivier Certner > AuthorDate: 2024-02-26 18:12:42 +0000 > Commit: Olivier Certner > CommitDate: 2025-06-18 02:07:56 +0000 > > runq: Deduce most parameters, remove machine headers > > The 'runq' machinery now depends on only two settable parameters, > RQ_MAX_PRIO, the maximum priority number that can be accepted, the > minimum being 0, and RQ_PPQ, the number of priorities per queue (to > reduce the number of queues). > > All other parameters are deduced from these ones. Also, all > architectures automatically get a runq word that is their natural word. > > RQB_FFS() always was 'ffsl() - 1' except for amd64 where it was > 'bsfq()'. Now that all these finally call compiler builtins, the > resulting assembly code is the same, so there is no cost to removing > this special case. > > After all these changes, headers have no more purpose, > so remove them. > > While here, fix potentially confusing parameter name for RQB_WORD() and > RQB_BIT(). > > While here, include all necessary headers so that can be > included standalone. > > No functional change (intended). > > Reviewed by: kib > MFC after: 1 month > Event: Kitchener-Waterloo Hackathon 202506 > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D45387 > --- > sys/amd64/include/runq.h | 46 -------------------------------------- > sys/arm/include/runq.h | 46 -------------------------------------- > sys/arm64/include/runq.h | 50 ----------------------------------------- > sys/i386/include/runq.h | 46 -------------------------------------- > sys/kern/kern_switch.c | 6 ++--- > sys/kern/sched_ule.c | 6 ++--- > sys/powerpc/include/runq.h | 55 ---------------------------------------------- > sys/riscv/include/runq.h | 44 ------------------------------------- > sys/sys/runq.h | 25 ++++++++++++++++++--- > 9 files changed, 27 insertions(+), 297 deletions(-) make buildworld is broken on arm64. Is this missing? diff --git a/include/arm/Makefile b/include/arm/Makefile index 1f596763df77..27fa8dfb9de3 100644 --- a/include/arm/Makefile +++ b/include/arm/Makefile @@ -32,7 +32,6 @@ INCS= _align.h \ reg.h \ reloc.h \ resource.h \ - runq.h \ setjmp.h \ signal.h \ sysarch.h \