From owner-svn-src-head@FreeBSD.ORG Thu May 16 21:16:16 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 9CD253BE; Thu, 16 May 2013 21:16:16 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) by mx1.freebsd.org (Postfix) with ESMTP id 72E0165B; Thu, 16 May 2013 21:16:16 +0000 (UTC) Received: from Julian-MBP3.local ([137.122.64.21]) (authenticated bits=0) by vps1.elischer.org (8.14.5/8.14.5) with ESMTP id r4GLGAAL019920 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 16 May 2013 14:16:11 -0700 (PDT) (envelope-from julian@freebsd.org) Message-ID: <51954C96.3060409@freebsd.org> Date: Thu, 16 May 2013 17:16:06 -0400 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Ed Schouten Subject: Re: svn commit: r250700 - in head/sys: conf net netinet6 sys References: <201305161620.r4GGKIFI012296@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 May 2013 21:16:16 -0000 On 5/16/13 3:19 PM, Ed Schouten wrote: > Hey Julian, > > 2013/5/16 Julian Elischer : >> #define M_SETFIB(_m, _fib) do { \ >> - _m->m_flags &= ~M_FIB; \ >> - _m->m_flags |= (((_fib) << M_FIBSHIFT) & M_FIB); \ >> + KASSERT((_m)->m_flags & M_EXT, ("No FIB on non header mbuf")); \ >> + ((_m)->m_pkthdr.fibnum) = (_fib); \ >> } while (0) > This KASSERT triggers on my box at home. Sorry, but busy right now, so > I can't spend too much time debugging this. Right after getting a > DHCPACK on bootup, the box panics. Copied by hand: thanks My face is red because while this indicates a bug in someone else's code, I should have caught it myself.. but guess what? I accidentally turned off invariants.. duh! I will track down the errant code and fix.. Julian > > panic: No FIB on non header mbuf > .. > db> bt > kassert_panic() > rt_newaddrmsg_fib() > rtinit1() > in_scrubprefix() > in_control() > ifioctl() > kern_ioctl() > sys_ioctl() > amd64_syscall() > Xfast_syscall() > > -- > Ed Schouten >