From owner-freebsd-hackers@FreeBSD.ORG  Thu Jan 12 10:38:52 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5BFEC1065678;
	Thu, 12 Jan 2012 10:38:52 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from mx0.hoeg.nl (mx0.hoeg.nl [IPv6:2a01:4f8:101:5343::aa])
	by mx1.freebsd.org (Postfix) with ESMTP id 1A6688FC27;
	Thu, 12 Jan 2012 10:38:52 +0000 (UTC)
Received: by mx0.hoeg.nl (Postfix, from userid 1000)
	id 7E9F62A28CC6; Thu, 12 Jan 2012 11:38:51 +0100 (CET)
Date: Thu, 12 Jan 2012 11:38:51 +0100
From: Ed Schouten <ed@80386.nl>
To: Kostik Belousov <kostikbel@gmail.com>
Message-ID: <20120112103851.GF5300@hoeg.nl>
References: <CAF6rxg=EjkwFbXQt3i2Nnz6_dcZtdek-2YdqyZnAdVPxVaWR_Q@mail.gmail.com>
	<20120112100840.GV31224@deviant.kiev.zoral.com.ua>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="2XUWoe1nmt7t49kG"
Content-Disposition: inline
In-Reply-To: <20120112100840.GV31224@deviant.kiev.zoral.com.ua>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: jilles@freebsd.org, Eitan Adler <lists@eitanadler.com>,
	Colin Percival <cperciva@freebsd.org>,
	FreeBSD Hackers <freebsd-hackers@freebsd.org>
Subject: Re: dup3 syscall - atomic set O_CLOEXEC with dup2
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jan 2012 10:38:52 -0000


--2XUWoe1nmt7t49kG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Kostik,

* Kostik Belousov <kostikbel@gmail.com>, 20120112 11:08:
> > +int
> > +sys_dup3(struct thread * const td, struct dup3_args * const uap) {
> The td and uap are not constant in the prototypes generated by
> makesyscalls.sh. This makes me seriosly wonder was the patch compiled at
> all.

This is because the parameters itself are const -- not the objects they
point to. e.g:

int foo(int);

int foo(const int i)
{
	/* code here */
}

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--2XUWoe1nmt7t49kG
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)

iQIcBAEBAgAGBQJPDrg7AAoJEG5e2P40kaK7dSwQAIbXS2yRIFsxLAMWF24SaMd1
61Q2pkoFcyW5r4NRoz9jgCs+xdyqBGaeL+pkTNc4DxWxbJjjX9fODsqSXFz+Dn+A
Bzybm2FtXyzdCgXH93rLISB0zNd3/BUcIPffiH9twphLEFSNQ0ikLLuhL+uDPppX
pwtwRUEx9nlFiYLdRds2TqWOqnvgF04RXIzY5bo7Ltuzu4hicFuUtP9YzRLPmp7n
D2l/U7bXCnhtT0/dgRv04WYpdjSDGF/ibltUsTh27lqdwkCAEuiRtJJ/s+SM8YfL
AUVp8brSAJJwSgv3vrEAz0tNtzHixzMmzZfi1XaEIfu57PV2VWUDFn83N6Ys3DT5
wImgI8PdRu14PKfKpRdFf+tqtGIjjwKX3WpLu24rWMQTg+8jwcvyVDzXUXR2YR4+
2nUmBbtGR6hzVPWL0z+eU0s+E3VyVphjvVxz/+QvfQuGdECySxaKu7+LcidXrfE/
bfwYgVu+tuB7/Y5vFRTBF9LvsMwDw9eEi28QMhL8P+9wVjY1OyRWzQ3YpmPwtg1k
EzFd8zZgzRuslxQQlxoJy8LRBLWybZ5YqiYoDLZ2ardnFnBGAzodPCG12H44gUTq
56ImFnBuUKlpZK8GS5QYLxjF8tNigqChd2N/3dMwI2DODuoB2G09NSZB9+YcJ1jx
+olLCtOamANfsfFuQ1O0
=BNjK
-----END PGP SIGNATURE-----

--2XUWoe1nmt7t49kG--