From owner-cvs-all@FreeBSD.ORG  Fri Feb  1 13:48:34 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 4BA8116A469; Fri,  1 Feb 2008 13:48:34 +0000 (UTC)
Date: Fri, 1 Feb 2008 13:48:34 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Beech Rintoul <beech@FreeBSD.org>
Message-ID: <20080201134834.GA54677@FreeBSD.org>
References: <200801311929.m0VJTU0t086567@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200801311929.m0VJTU0t086567@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/multimedia/xmms Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Feb 2008 13:48:34 -0000

On Thu, Jan 31, 2008 at 07:29:30PM +0000, Beech Rintoul wrote:
> beech       2008-01-31 19:29:30 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     multimedia/xmms      Makefile 
>   Log:
>   - Add options
>   - Pet portlint
>   - Bump portrevision
>   - Take maintainership

Couple of questions:

- Option descriptions could've been expanded (missing "Build
  with"/"Enable" as vast majority of other ports do)
- It seems that "ipv6" could be better spelled as "IPv6", and "Plugin"
  as mere "plugin"; ditto for "Fileinfo"
- Mixing OPTIONS and @${ECHO_MSG} "You can enable ... by defining
  WITH_FOO" looks strange, any particular reason for that?

./danfe