From nobody Wed Apr 15 17:32:38 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fwpBK5HRmz6ZBNM; Wed, 15 Apr 2026 17:32:41 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fwpBK4gc8z3CTs; Wed, 15 Apr 2026 17:32:41 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776274361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PEtayJ1nHSbFs8WrvxLt61MkmKrPjnUIBjIOfYQR8zM=; b=LzCg9XAtJZq1wLFtaiykXnGXInhqiF+bSNBC5fHYccOr/tgLDBDc9p7fb8wIRqZ2cscWFj D03B63U3yH1DlmUBzMlKcMkI01XcZPbFBbd22ndQ7CcId29EBQV4mvWGw2qNyCWqfrv2/u ox5RU7Cl6zROPTBPRjbVYYUZIfjFALK0JWM32XXmU3aVvMdBNb5Jhy0G5Ka0gyPWmbTd2F 46VnQQsCBaCbTeDNugRn6tJRI+RT15gxW+2uQHtCBGwyOenYxXuGTShq4ha01kdK7Lt6je hQ015hbvmsXfKPyAz4M71ZAmaQ4U8KSK6e4F9PwsVTqJXJD8MQ8V8yhD0xDBjg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776274361; a=rsa-sha256; cv=none; b=IsVkQBFOORFNMCKdhwJU+m3dgHJ+ByDrUjV1hYrcXFCxPiG+SqETZWQf5kI1/R2a/HSkIu CZof5VhuHWf/rh2SDGtrM3PIO27xjASvypfp/De/UyGP6Q+Py8c1/UohvZ7Lg5/7MR25f2 8IWtMHPA+5EspKYMU69vEJ1JCmdRsVlC8p5jV55AhBMtsyTgZ5QozTLM8d/AxE4vCr0l3K d7wzEHmFgVdfOodewUPKleXLPZ1GUjvFsUfdW0Ro7EtyT3yphNsuhDMYBJJqOjbxmvU29I +NzZEumzcpDPzzF3UztfFfyu7qRb6slF0UWbJr+xhMNTI1MP81DJPwEMbiuMhg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776274361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PEtayJ1nHSbFs8WrvxLt61MkmKrPjnUIBjIOfYQR8zM=; b=kUfS+y3cChDdU1EHGQlAAZRRovlZwl3bmsBfLPh96EAGBaAs/HU5PUiO35TtdImcpAAlJz 9SKIeUD8CQGDxPD/D9PjMqC4TYb1tVD47HQD/pGdo+dtvN0g6OyWDe6runH0WKes9lG+wC RWrPQmarZ6Rz6DYUsuQ4IcrLUA7ThumQdbMdZ3F9kdcqEpi4F83B/zXGW7qyhhjVzs3WLM 4ZpKIJMXuc8fFOT9fBaafZOLzbK9dW1QXrto8vTmBDedGxAsDl2lmunUuXVo4IhnG8xtTh WGSWukKgnN45RhLioHL4guLXsCjzGL+6cd9Wwrot/2aXWwBEwGJovZtjwwHxLQ== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fwpBK0FZMztTx; Wed, 15 Apr 2026 17:32:40 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Wed, 15 Apr 2026 10:32:38 -0700 From: Gleb Smirnoff To: John Baldwin Cc: np@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4fadf2466468 - main - tcp_close: Use in6_pcbdisconnect for INET6 sockets Message-ID: References: <69de895e.398d0.7253ff8b@gitrepo.freebsd.org> <45629508-bfcb-4161-8913-470539b479ad@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45629508-bfcb-4161-8913-470539b479ad@FreeBSD.org> On Wed, Apr 15, 2026 at 10:48:38AM -0400, John Baldwin wrote: J> On 4/14/26 18:13, Gleb Smirnoff wrote: J> > On Tue, Apr 14, 2026 at 06:37:18PM +0000, John Baldwin wrote: J> > J> The branch main has been updated by jhb: J> > J> J> > J> URL: https://cgit.FreeBSD.org/src/commit/?id=4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 J> > J> J> > J> commit 4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 J> > J> Author: John Baldwin J> > J> AuthorDate: 2026-04-14 18:07:51 +0000 J> > J> Commit: John Baldwin J> > J> CommitDate: 2026-04-14 18:07:51 +0000 J> > J> J> > J> tcp_close: Use in6_pcbdisconnect for INET6 sockets J> > J> J> > J> This also fixes the LINT-NOINET builds. J> > J> J> > J> Fixes: 40dbb06fa73c ("inpcb: retire INP_DROPPED and in_pcbdrop()") J> > J> > I think this change is also required. J> > J> > Almost sure it will fix panic observed by Navdeep. J> J> Yes, I had missed that when comparing the two. J> J> Given how similar this functions are, I wonder if in_pcbdisconnect() should be a shared J> method that just has a few AF-specific bits of code? The old in_pcbdrop() function was J> shared and not INET vs INET6 specific. Absolutely. I have this on my list. -- Gleb Smirnoff