From owner-cvs-all Mon Dec 6 5:15: 8 1999 Delivered-To: cvs-all@freebsd.org Received: from knight.cons.org (knight.cons.org [194.233.237.195]) by hub.freebsd.org (Postfix) with ESMTP id 3949315129; Mon, 6 Dec 1999 05:15:04 -0800 (PST) (envelope-from cracauer@knight.cons.org) Received: (from cracauer@localhost) by knight.cons.org (8.9.3/8.9.3) id OAA08577; Mon, 6 Dec 1999 14:14:57 +0100 (CET) Date: Mon, 6 Dec 1999 14:14:57 +0100 From: Martin Cracauer To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/bin/sh expand.c parser.c Message-ID: <19991206141456.A8553@cons.org> References: <199912041712.JAA38380@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.1i In-Reply-To: <199912041712.JAA38380@freefall.freebsd.org>; from Martin Cracauer on Sat, Dec 04, 1999 at 09:12:49AM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk In <199912041712.JAA38380@freefall.freebsd.org>, Martin Cracauer wrote: > cracauer 1999/12/04 09:12:49 PST > > Modified files: > bin/sh expand.c parser.c > Log: > Fix "subscript has type `char'" warnings by casting to int, as > discussed on -arch. Before any more people point it out: sh is not even remotely 8-bit clean and double-casting (int)(usigned char)c to expand a negative sign to += 128 makes things worse, not better. Not sure wether I should give it a try before the feature freeze. Anyone has scripts with umlauts he wants to submit for testing? Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer http://www.cons.org/cracauer/ Tel.: (private) +4940 5221829 Fax.: (private) +4940 5228536 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message