From nobody Fri Feb 6 19:00:55 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f73Nb1DjXz6FT5F; Fri, 06 Feb 2026 19:01:51 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from fhigh-a2-smtp.messagingengine.com (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4f73NZ6RQFz3PKK; Fri, 06 Feb 2026 19:01:50 +0000 (UTC) (envelope-from herbert@gojira.at) Authentication-Results: mx1.freebsd.org; none Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 6504B1400050; Fri, 6 Feb 2026 14:01:50 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Fri, 06 Feb 2026 14:01:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gojira.at; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1770404510; x=1770490910; bh=sXWfv/dqqn kreFQ+nhP5N7tqcGOaA1FwTuWOSwYWzGY=; b=TYMrotY3qA9RICgXpSOzJ3WbXc BiQZzM5iRcBXEj4fca/uFX42qhfBxyXpJlXi1HHLJZuRKENGKMHsm7S7boLvErWd aMiDXYUOlq2xcPFjww4Nw++tdcMISfvb6TBVJyOrZ43i+kLHEqdRkhSIOr8XixBh wq4AVv/ATpmRNrT4SsoA4cKDo11R3aSfKQpKSsA+AvPoo755mMmo3+FHWeZhWArS MamiTE8MfOd44FQpTRq6ieR36L3+r2cuD4JXuRkQxH1Q3RWuLH6amADy7Na6p6D0 PMxE/doHhkS1rcgxK15nlfY0VGfB82FO7BCwVJYQG9P9keWaoS5op4kUxbDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1770404510; x=1770490910; bh=sXWfv/dqqnkreFQ+nhP5N7tqcGOaA1FwTuW OSwYWzGY=; b=l5bMcODT7cp1cfWck+4J1LZ8Gxp2L+cPSQ/Zzfjv2tpBGuXA+FZ XgP7WARy74ZnblIHZVN43QO7cgEmiGNV/yH6787DACDTREA+QmLTb967OyOBrQs8 MekvadkhdiqNmeBcAUDX7oiaR1F0HazyAre717YVQydQnevitiAx5DF3JLXOARC5 qx4ZRn4S0nJeZ2pqvZcZ5wzMT7HlrCBex8YA9k37MMd/neM1OC6L4lvmJGlMqe/Q 1fEvyJESsCG+q4K+x3r3He3UrZVJl2RDeamt/ikVGWVBlw+CK4/7qEZEX6Yk8Yyz 8IZ8061Q39PtCrMbaSkcz4x4rJ+CGjD4YFg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddukeekleehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffkhffvvefujghffgggtgesthdtredttdervdenucfhrhhomhepfdfjvghrsggv rhhtucflrdcuufhkuhhhrhgrfdcuoehhvghrsggvrhhtsehgohhjihhrrgdrrghtqeenuc ggtffrrghtthgvrhhnpeefhfehffegvdehuedtuefgkeefieffieejhfeggeekgeevjeeg feffgeeglefhtdenucffohhmrghinhepfhhrvggvsghsugdrohhrghenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhvghrsggvrhhtsehgohhj ihhrrgdrrghtpdhnsggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprhgtph htthhopeholhgtvgesfhhrvggvsghsugdrohhrghdprhgtphhtthhopehsrhgtqdgtohhm mhhithhtvghrshesfhhrvggvsghsugdrohhrghdprhgtphhtthhopeguvghvqdgtohhmmh hithhsqdhsrhgtqdgrlhhlsehfrhgvvggsshgurdhorhhgpdhrtghpthhtohepuggvvhdq tghomhhmihhtshdqshhrtgdqmhgrihhnsehfrhgvvggsshgurdhorhhg X-ME-Proxy: Feedback-ID: i64fe486c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 6 Feb 2026 14:01:49 -0500 (EST) Date: Fri, 06 Feb 2026 20:00:55 +0100 Message-ID: <87qzqxlms8.wl-herbert@gojira.at> From: "Herbert J. Skuhra" To: Olivier Certner Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 804329587508 - main - hwpstate{_amd,intel}(4): Move common knobs to a separate file In-Reply-To: <69861577.1d172.fd5fa27@gitrepo.freebsd.org> References: <69861577.1d172.fd5fa27@gitrepo.freebsd.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/31.0 Mule/6.0 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:151847, ipnet:103.168.172.0/24, country:AU] X-Rspamd-Queue-Id: 4f73NZ6RQFz3PKK X-Spamd-Bar: ---- On Fri, 06 Feb 2026 17:23:19 +0100, Olivier Certner wrote: > > The branch main has been updated by olce: > > URL: https://cgit.FreeBSD.org/src/commit/?id=8043295875083b57a6b7b2dc6826fde4cf4e1ba1 > > commit 8043295875083b57a6b7b2dc6826fde4cf4e1ba1 > Author: Olivier Certner > AuthorDate: 2026-02-06 10:58:07 +0000 > Commit: Olivier Certner > CommitDate: 2026-02-06 16:23:07 +0000 > > hwpstate{_amd,intel}(4): Move common knobs to a separate file > > Reason for doing this right now is to resolve the conflict on > 'machdep.hwpstate_pkg_ctrl' between the Intel and AMD drivers, even > though I expect to remove it for hwpstate_amd(4) at some point. > > More generally, this is going to be useful for some future code > factorization. Also, the 'debug.hwpstate_verbose' knob was moved there, > as we'll likely want to use it for the Intel driver as well (which is > currently not the case). > > Note for MFC: Will be partial, since `hwpstate_amd(4)` does not support > CPPC in stable/15 nor stable/14. > > Reviewed by: emaste > Fixes: 3e6e4e4a0d42 ("hwpstate: add CPPC support for pstate driver on AMD") > MFC after: 2 weeks > Differential Revision: https://reviews.freebsd.org/D54528 > --- > sys/conf/files.x86 | 1 + > sys/modules/cpufreq/Makefile | 3 ++- > sys/x86/cpufreq/hwpstate_amd.c | 11 ++--------- > sys/x86/cpufreq/hwpstate_common.c | 22 ++++++++++++++++++++++ > sys/x86/cpufreq/hwpstate_common.h | 13 +++++++++++++ > sys/x86/cpufreq/hwpstate_intel.c | 6 +----- > 6 files changed, 41 insertions(+), 15 deletions(-) This commit seems to break GENERIC_NODEBUG.