From owner-svn-src-all@FreeBSD.ORG Sun May 10 14:06:06 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E1F516B5; Sun, 10 May 2015 14:06:06 +0000 (UTC) Received: from relay.mailchannels.net (tkt-001-i373.relay.mailchannels.net [174.136.5.175]) by mx1.freebsd.org (Postfix) with ESMTP id 62BFA11AA; Sun, 10 May 2015 14:06:04 +0000 (UTC) X-Sender-Id: duocircle|x-authuser|hippie Received: from smtp3.ore.mailhop.org (ip-10-213-14-133.us-west-2.compute.internal [10.213.14.133]) by relay.mailchannels.net (Postfix) with ESMTPA id 3D8351007AF; Sun, 10 May 2015 13:59:12 +0000 (UTC) X-Sender-Id: duocircle|x-authuser|hippie Received: from smtp3.ore.mailhop.org (smtp3.ore.mailhop.org [10.45.8.167]) (using TLSv1 with cipher DHE-RSA-AES256-SHA) by 0.0.0.0:2500 (trex/5.4.8); Sun, 10 May 2015 13:59:12 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: duocircle|x-authuser|hippie X-MailChannels-Auth-Id: duocircle X-MC-Loop-Signature: 1431266352352:4141350547 X-MC-Ingress-Time: 1431266352351 Received: from c-73-34-117-227.hsd1.co.comcast.net ([73.34.117.227] helo=ilsoft.org) by smtp3.ore.mailhop.org with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.82) (envelope-from ) id 1YrRl8-0002vc-Io; Sun, 10 May 2015 13:59:10 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t4ADx7NF073687; Sun, 10 May 2015 07:59:07 -0600 (MDT) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX19QaaxbbqXvyH6+bjYpTiS9 Message-ID: <1431266347.6170.221.camel@freebsd.org> Subject: Re: svn commit: r282726 - head/lib/libmd From: Ian Lepore To: Thomas Quinot Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sun, 10 May 2015 07:59:07 -0600 In-Reply-To: <201505101321.t4ADLa54030049@svn.freebsd.org> References: <201505101321.t4ADLa54030049@svn.freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-AuthUser: hippie X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 May 2015 14:06:07 -0000 On Sun, 2015-05-10 at 13:21 +0000, Thomas Quinot wrote: > Author: thomas > Date: Sun May 10 13:21:36 2015 > New Revision: 282726 > URL: https://svnweb.freebsd.org/changeset/base/282726 > > Log: > Ensure libmd symbols do not clash with libcrypto > > Add a prefix to all symbols in libmd to avoid incompatibilites > with same-named, but not binary compatible, symbols from libcrypto. > > Also introduce Weak aliases to avoid the need to rebuild dependent > binaries and a major version bump. > > PR: 199119 > Differential Revision: D2216 > Reviewed by: roberto, delphij > MFC after: 2 weeks > > Modified: > head/lib/libmd/md4.h > head/lib/libmd/md4c.c > head/lib/libmd/md5.h > head/lib/libmd/md5c.c > head/lib/libmd/mdXhl.c > head/lib/libmd/ripemd.h > head/lib/libmd/rmd160c.c > head/lib/libmd/sha.h > head/lib/libmd/sha1c.c > head/lib/libmd/sha256.h > head/lib/libmd/sha256c.c > head/lib/libmd/sha512.h > head/lib/libmd/sha512c.c > head/lib/libmd/shadriver.c This appears to break bootstrapping, at least when cross-building ARM on a 10-stable build host. The build runs for about 15 seconds before hitting... --- _bootstrap-tools-usr.bin/xinstall --- xinstall.o: In function `install': /local/build/staging/freebsd/wand/src/usr.bin/xinstall/xinstall.c:(.text+0xdff): undefined reference to `_libmd_MD5File' /local/build/staging/freebsd/wand/src/usr.bin/xinstall/xinstall.c:(.text+0x12ee): undefined reference to `_libmd_MD5Init' /local/build/staging/freebsd/wand/src/usr.bin/xinstall/xinstall.c:(.text+0x12fa): undefined reference to `_libmd_RIPEMD160_File' [quite a few more symbols listed] Complete log is here (command includes -DNO_CLEAN, but objdir started out empty). http://pastebin.com/v3iSZpSJ -- Ian