From owner-cvs-all@FreeBSD.ORG  Thu Apr  3 07:55:34 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 065EF37B401; Thu,  3 Apr 2003 07:55:34 -0800 (PST)
Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3B56E43F75; Thu,  3 Apr 2003 07:55:33 -0800 (PST)
	(envelope-from obrien@NUXI.com)
Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1])
	by dragon.nuxi.com (8.12.9/8.12.7) with ESMTP id h33FtDD0017961;
	Thu, 3 Apr 2003 07:55:14 -0800 (PST)
	(envelope-from obrien@dragon.nuxi.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h33FtCuR017960;
	Thu, 3 Apr 2003 07:55:12 -0800 (PST)
Date: Thu, 3 Apr 2003 07:55:12 -0800
From: "David O'Brien" <obrien@FreeBSD.org>
To: Bruce Evans <bde@zeta.org.au>
Message-ID: <20030403155512.GB17860@dragon.nuxi.com>
References: <200304030513.h335DR60079544@repoman.freebsd.org>
	<20030402231638.A81523@FreeBSD.org>
	<20030403055049.GA67232@dhcp01.pn.xcllnt.net>
	<20030403180026.A29934@gamplex.bde.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030403180026.A29934@gamplex.bde.org>
User-Agent: Mutt/1.4i
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD Group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
cc: Juli Mallett <jmallett@FreeBSD.org>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Marcel Moolenaar <marcel@xcllnt.net>
Subject: Re: cvs commit: src/libexec/talkd announce.c extern.h print.c
	table.c talkd.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: obrien@FreeBSD.org
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Apr 2003 15:55:34 -0000

On Thu, Apr 03, 2003 at 06:04:25PM +1000, Bruce Evans wrote:
> On Wed, 2 Apr 2003, Marcel Moolenaar wrote:
> 
> > Please, everybody, do not set WARNS=5 on anything because it breaks
> > non-optimized builds:
> >
> > cc -g -mcpu=pentiumpro -I/usr/local/src/fpi/cpu/..   -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
> > -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wuninitialized  -c decode.c
> > cc1: warnings being treated as errors
> > cc1: warning: -Wuninitialized is not supported without -O
> > *** Error code 1
...
> This is mostly a bug in the implementation of WARNS.

Agreed.  Lets fix it instead of not using warns 5 & 6.