From owner-svn-src-all@freebsd.org Thu Apr 14 16:43:41 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ACAA6ADA6B7 for ; Thu, 14 Apr 2016 16:43:41 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 75100176C for ; Thu, 14 Apr 2016 16:43:41 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x230.google.com with SMTP id g185so109418078ioa.2 for ; Thu, 14 Apr 2016 09:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=MHCE9KE2J8Wfhp0eb/RSM/LiNlgxpWscoM7V+VROCGM=; b=dE73F65JCIoCEIrk8qbvIwG9KWOU/BusjE4daEeJ0YhcVyMOBr0YDH+f8bZWVba+E0 i6sxKEfB9RlqwKc+fuKnDBS8gbrGAE/IlwkfezIKKA2D3MjxjcTMFFDTrebDqZ1bmb6a gAsfFC3shlVgTX89FZdMP/79byWBtfuDvL2Vhb6U91ra6W7GyL25r7mS/J8DciZJHZa5 atAMCsYv4G0e2agT5iC78HmmqNdpa0rOUuvbIiSAPo/I+omzLm3to5e+zhM7oPycqqld FoKIrraz8O8O9Od5x/YIFhhwMI+FX5niU1c3SHFZOpJyLKiQXTpsPMm7bIvTKcTs1yCJ mjjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=MHCE9KE2J8Wfhp0eb/RSM/LiNlgxpWscoM7V+VROCGM=; b=PxwoEvWrT+luh7qpXUXghd+130TA65h8ZHzDJuAhOZ6b12102dlGSsLeclEBf7j+gZ hgqovkzxE67Pfgm07geRyWwPRYLu6z/o0NIqWNaYIKjmJK1K4mVz72KP7S1ECD/WGF6A ORsKx1q2k1ucW3igXDTBGfVFTqP/bhFFi1+XTDKibHOu5pFOvLn7wMHm2g0nBwcEvotN wPqS4wnq4jFMbw1XV7ZfGALYpO93EJuEPztjo0YDOcQUFaRGNLjK03wlmdR1tq/sazdT 4pQ/0+7GEZzZ7PE0m7hZgnKWPFHVyu26KbGb/OOAh3QYow9S00xxqRSNqsDz2ge3ISAD Ot8w== X-Gm-Message-State: AOPr4FUMNfRTIgNnaW0M9WEQKVhWY544uOkz5wx/E46pgfIH7L93DkTKOpIDWnCF9C5jX/AeWIGXReYmP7Q23Q== MIME-Version: 1.0 X-Received: by 10.107.145.9 with SMTP id t9mr14841187iod.135.1460652220598; Thu, 14 Apr 2016 09:43:40 -0700 (PDT) Sender: wlosh@bsdimp.com Received: by 10.36.194.3 with HTTP; Thu, 14 Apr 2016 09:43:40 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: <20160414092229.1ba8d6c5@zapp> References: <201604140459.u3E4xpYv038183@repo.freebsd.org> <20160414092229.1ba8d6c5@zapp> Date: Thu, 14 Apr 2016 10:43:40 -0600 X-Google-Sender-Auth: TmGhpTFJRUaoji9SUxTBKEKo9jw Message-ID: Subject: Re: svn commit: r297954 - in head/sys: boot/efi/loader/arch/amd64 boot/i386/libi386 x86/acpica From: Warner Losh To: Andrew Turner Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2016 16:43:41 -0000 On Thu, Apr 14, 2016 at 2:22 AM, Andrew Turner wrote: > On Thu, 14 Apr 2016 04:59:51 +0000 (UTC) > Warner Losh wrote: > > > Author: imp > > Date: Thu Apr 14 04:59:51 2016 > > New Revision: 297954 > > URL: https://svnweb.freebsd.org/changeset/base/297954 > > > > Log: > > Deprecate using hints.acpi.0.rsdp to communicate the RSDP to the > > system. This uses the hints mechnanism. This mostly works today > > because when there's no static hints (the default), this value can > > be fetched from the hint. When there is a static hints file, the hint > > passed from the boot loader to the kernel is ignored, but for the > > BIOS case we're able to find it anyway. However, with UEFI, the > > fallback doesn't work, so we get a panic instead. > > > > Switch to acpi.rsdp and use TUNABLE_ULONG_FETCH instead. Continue to > > generate the old values to allow for transitions. In addition, fall > > back to the old method if the new method isn't present. > > > > Add comments about all this. > > > > Differential Revision: https://reviews.freebsd.org/D5866 > > Why not pass it in using module data as we do with the DTB? It would > fix issues where we have either or both static hints and a stat env. > I viewed that as brittle. And it was longer to code. This works with static hints, but not static env. Static env tends not to be used on x86. I'm open to putting it into module data as a more robust solution. I just didn't have the extra time it would take to do so at the moment. > Whatever method is decided we will also need it on arm64 as we claim to > support ACPI there, although no backwards compatibility will be needed > as the code is most likely broken as it's only partially been tested. > Yes. The issue is with ACPI + UEFI. With ACPI + BIOS, we could find things always, and this didn't matter. This change doesn't change that. But for UEFI, the RSDP table can be (and often is) located in areas the code doesn't search. We likely need to unify more than just passing in the RSDP, since if we want to callout to UEFI after the kernel has booted, there's a number of other things that need to be passed as well. I have a review that gets this working on x86 that I'll open up when more of my backlog has been pushed into the tree. I'll be sure to include you. Warner